Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJS v6 release + support #21572

Closed
15 of 18 tasks
IgorMinar opened this issue Jan 16, 2018 · 20 comments
Closed
15 of 18 tasks

RxJS v6 release + support #21572

IgorMinar opened this issue Jan 16, 2018 · 20 comments
Assignees
Labels
area: core Issues related to the framework runtime feature Issue that requests a new feature
Milestone

Comments

@IgorMinar
Copy link
Contributor

IgorMinar commented Jan 16, 2018

Work breakdown:

@IgorMinar IgorMinar added this to the v6.0 milestone Jan 16, 2018
@shyamal890
Copy link

shyamal890 commented Jan 21, 2018

Request to add work bullet point addressing #19705 issue (updateOn debounce support in input)

@mhevery mhevery added feature Issue that requests a new feature area: core Issues related to the framework runtime labels Jan 23, 2018
@IgorMinar IgorMinar self-assigned this Feb 1, 2018
@IgorMinar
Copy link
Contributor Author

@shyamal890 that's totally unrelated to rxjs (it's a forms feature request) and unfortunately something that will have to wait due to all the other changes going on. I expect that we'll take a closer look at forms after v6.0 is out.

@michaeljota
Copy link

I know that rxjs was in RC when integrated in Angular, but now that this is stable, is still the plan to integrate a new version of rxjs that is currently in RC? Or this will be postponed until rxjs@6 is stable?

@sarunint
Copy link
Contributor

What is stable? I believe both Angular and RxJS are still in release candidate.

@michaeljota
Copy link

Angular have several stable releases, and I wonder if this is something the team will wait for before launching stable 6

@sarunint
Copy link
Contributor

Current stable version of Angular, v5.x, depends on RxJS version 5.x, which is also stable.

I think RxJS and Angular will reach v6 stable at almost the same time. (Well, the RxJS lead is also on the Angular core team)

@michaeljota
Copy link

I know, but RxJS had a rewrite between Angular 2 and 4, and I'm almost sure that then Angular 2 was released, rxjs was added in a RC version, as the final was not stable.

Angular 6 was schedule for early April, and we are late (pun unintended). I wonder if waiting for rxjs going stable is one of the things keeping 6 to being release as well.

@MattiJarvinen
Copy link

RxJS 6 is released @michaeljota https://github.com/ReactiveX/rxjs/releases/tag/6.0.0

I bet this issue is solved within a week.

@gwelr
Copy link

gwelr commented May 30, 2018

With the release of both Angular 6 and Rxjs 6, documentation is no longuer accurate. I saw the the work breakdown at the top of this ticket, but with the importance of Observable and Rxjs in Angular, I believe it is important to update the documentation.

Eg: https://angular.io/guide/rx-library#observable-creation-functions is no longuer valid.

it should be:

import { from } from 'rxjs';

// Create an Observable out of a promise
const data = from(fetch('/api/endpoint'));
// Subscribe to begin listening for async result
data.subscribe({
 next(response) { console.log(response); },
 error(err) { console.error('Error: ' + err); },
 complete() { console.log('Completed'); }
});

@alfaproject
Copy link
Contributor

alfaproject commented May 30, 2018

I still can't get rid of rxjs-compat because zone.js depends on it.
@JiaLiPassion any ETA to refactor that?

@MattiJarvinen
Copy link

@alfaproject what is your current zone.js version?

@alfaproject
Copy link
Contributor

alfaproject commented May 30, 2018

@JiaLiPassion
Copy link
Contributor

@alfaproject, I am doing this now, I will try to make a test version next week.

@alexeagle alexeagle removed this from the v6.0 milestone Aug 10, 2018
@jasonaden jasonaden added this to the v7.0 milestone Aug 16, 2018
@mat3e
Copy link

mat3e commented Oct 19, 2018

@gwelr I was also confused after using fromPromise inside the application generated with Angular CLI. I've created a pull request for a documentation update.

@gwelr
Copy link

gwelr commented Oct 19, 2018

@mat3e congrats for your first PR. And it has already been reviewed. It seems your alias is considered redundant (at least for the documentation). EG:

import { from as from, Observable, of } from 'rxjs';

should be

import { from, Observable, of } from 'rxjs';

@mat3e
Copy link

mat3e commented Oct 19, 2018

Yes, the alias was fromPromise and I changed it 🤦‍♂️ it is already fixed.

@alfaproject
Copy link
Contributor

@JiaLiPassion it's been 6 months and I'm still requiring rxjs-compat because of unit testing. Any progress on that?

@JiaLiPassion
Copy link
Contributor

@alfaproject, it has been merged into zone.js master, but please wait for the next zone.js release.

@pkozlowski-opensource
Copy link
Member

We've been on RxJS 6.x for a while so I guess we can close this general issue. Please open new, focused issue(s) if there is any remaining work to be done.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests