docs: update observable from examples to RxJS V6 (#21572) #26588
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I fixed my e-mail data in cla. |
|
CLAs look good, thanks! |
| @@ -5,7 +5,7 @@ import { | |||
| NgModuleRef, | |||
| } from '@angular/core'; | |||
| import { ELEMENT_MODULE_PATHS_TOKEN } from './element-registry'; | |||
| import { from as fromPromise, Observable, of } from 'rxjs'; | |||
| import { from as from, Observable, of } from 'rxjs'; | |||
There was a problem hiding this comment.
Nit: redundant symbol alias ie: as from
| @@ -1,6 +1,6 @@ | |||
| import { Injectable } from '@angular/core'; | |||
|
|
|||
| import { from as fromPromise, Observable } from 'rxjs'; | |||
| import { from as from, Observable } from 'rxjs'; | |||
brandonroberts
added
comp: docs
action: review
From RxJS 6.0.0 there is just `from`, no `fromPromise` method.
brandonroberts
changed the title
|
Thanks for the PR @mat3e. These changes have already landed in master. If you see something else, open a new PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
From RxJS 6.0.0 there is just
from, nofromPromisemethod.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #21572
What is the new behavior?
Documentation contains just a
frommethod from RxJS.Does this PR introduce a breaking change?
Other information
My first PR :)