Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(aio): fix typo in "preserveWhitespaces" example #22182

Closed
wants to merge 1 commit into from

Conversation

benbraou
Copy link
Contributor

Fixes #22147

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The property name is "preserveWhiteSpaces" with uppercase "s" after "preserveWhite" (but should be "preserveWhitespaces" with lowercase "s" after "preserveWhite")

What is the new behavior?

preserveWhitespaces is used instead

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Maybe this PR should be merged after #22027 ? To avoid merge conflicts in aot-compiler.md for that PR ?

@IgorMinar IgorMinar requested a review from a team February 12, 2018 23:11
@ocombe ocombe requested review from a team and removed request for a team February 12, 2018 23:13
@IgorMinar IgorMinar removed the request for review from a team February 12, 2018 23:15
@IgorMinar IgorMinar self-assigned this Feb 12, 2018
@IgorMinar IgorMinar self-requested a review February 12, 2018 23:15
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@IgorMinar IgorMinar added comp: docs area: core Issues related to the framework runtime target: patch This PR is targeted for the next patch release type: bug/fix action: merge The PR is ready for merge by the caretaker labels Feb 12, 2018
@mhevery mhevery closed this in eb48750 Feb 12, 2018
mhevery pushed a commit that referenced this pull request Feb 12, 2018
@benbraou benbraou deleted the issue22147 branch February 13, 2018 01:55
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this pull request Feb 23, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
3 participants