New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize whitespace in template by default (preserveWhitespace to false by default) #22027

Closed
IgorMinar opened this Issue Feb 5, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@IgorMinar
Copy link
Member

IgorMinar commented Feb 5, 2018

In #18401 we implemented preserveWhitespace compiler flag to fix #11679.

Initially we made this an opt-in because of a possibility of subtle breaking changes related to applying styles to DOM with whitespace suddenly stripped from most nodes.

Now that we verified that the negative impact of this change at Google has been minimal, we should go ahead and make https://github.com/angular/angular/issues/11679 option set to false by default.

@IgorMinar IgorMinar referenced this issue Feb 5, 2018

Closed

Misc Framework improvements #21578

5 of 6 tasks complete

@IgorMinar IgorMinar added this to the v6-candidates milestone Feb 5, 2018

benbraou added a commit to benbraou/angular that referenced this issue Feb 6, 2018

benbraou added a commit to benbraou/angular that referenced this issue Feb 6, 2018

benbraou added a commit to benbraou/angular that referenced this issue Feb 6, 2018

benbraou added a commit to benbraou/angular that referenced this issue Feb 6, 2018

benbraou added a commit to benbraou/angular that referenced this issue Feb 7, 2018

benbraou added a commit to benbraou/angular that referenced this issue Feb 13, 2018

@vicb vicb closed this in f1a0632 Feb 16, 2018

smdunn pushed a commit to smdunn/angular that referenced this issue Feb 28, 2018

@StefanKern

This comment has been minimized.

Copy link

StefanKern commented Apr 24, 2018

Hey, Issue #21049 list a number of complains where this is change causes problems

@simeyla

This comment has been minimized.

Copy link

simeyla commented Dec 23, 2018

{{ ' ' }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment