Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore install-chromium.sh version checking once https://omahaproxy.appspot.com/all is back #22231

Closed
matsko opened this issue Feb 14, 2018 · 2 comments
Closed

Restore install-chromium.sh version checking once https://omahaproxy.appspot.com/all is back #22231

matsko opened this issue Feb 14, 2018 · 2 comments
Labels
area: build & ci Related the build and CI infrastructure of the project freq1: low type: bug/fix
Milestone
Backlog

Comments

@matsko
Copy link
Contributor

matsko commented Feb 14, 2018 •
edited

When travis runs this error pops up:

   creating: /home/travis/.chrome/chromium/chrome-linux/resources/inspector/security_test_runner/
  inflating: /home/travis/.chrome/chromium/chrome-linux/resources/inspector/security_test_runner/security_test_runner_module.js  
/home/travis/build/angular/angular/scripts/ci/install-chromium.sh: line 82: LATEST_CHROMIUM_VERSION: unbound variable

And it's due to https://omahaproxy.appspot.com/all being unresponsive.

Once that page is working again. We can uncomment and close this issue.
matsko added a commit to matsko/angular that referenced this issue Feb 14, 2018
@matsko
fix(build): comment-out chromium version checking code temporarily
3af4a9b 
Related angular#22231
@matsko matsko mentioned this issue Feb 14, 2018
Closed
matsko added a commit to matsko/angular that referenced this issue Feb 14, 2018
@matsko
build: comment-out chromium version checking code temporarily
9f3094e 
Related angular#22231
@IgorMinar
Copy link
Contributor

can you capture why it's failing now? the next caretaker will not know when it's safe to restore.

matsko added a commit that referenced this issue Feb 14, 2018
@matsko
build: comment-out chromium version checking code temporarily (#22232)
5bb9fca 
Related #22231

PR Close #22232
matsko added a commit that referenced this issue Feb 14, 2018
@matsko
build: comment-out chromium version checking code temporarily (#22232)
0b8b06e 
Related #22231

PR Close #22232
@vicb vicb added area: build & ci Related the build and CI infrastructure of the project type: bug/fix freq1: low severity3: broken labels Feb 15, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this issue Feb 23, 2018
@matsko @jbogarthyde
build: comment-out chromium version checking code temporarily (angula…
657aabc 
…r#22232)

Related angular#22231

PR Close angular#22232
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Feb 26, 2018
smdunn pushed a commit to smdunn/angular that referenced this issue Feb 28, 2018
@matsko @smdunn809
build: comment-out chromium version checking code temporarily (angula…
6cfc458 
…r#22232)

Related angular#22231

PR Close angular#22232
leo6104 pushed a commit to leo6104/angular that referenced this issue Mar 25, 2018
@matsko @leo6104
build: comment-out chromium version checking code temporarily (angula…
d9b016d 
…r#22232)

Related angular#22231

PR Close angular#22232
gkalpak added a commit to gkalpak/angular that referenced this issue Aug 21, 2018
@gkalpak
build: check for latest Chromium version
1145dfc 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes angular#22231
@gkalpak gkalpak mentioned this issue Aug 21, 2018
Closed
gkalpak added a commit to gkalpak/angular that referenced this issue Aug 22, 2018
@gkalpak
build: check for latest Chromium version
b7348d4 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes angular#22231
gkalpak added a commit to gkalpak/angular that referenced this issue Aug 23, 2018
@gkalpak
build: check for latest Chromium version
9efe96c 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes angular#22231
@matsko matsko closed this as completed in efb453c Aug 24, 2018
gkalpak added a commit to gkalpak/angular that referenced this issue Aug 25, 2018
@gkalpak
build: check for latest Chromium version (angular#25602)
44ac5ae 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes angular#22231

PR Close angular#25602
mhevery pushed a commit that referenced this issue Sep 5, 2018
@gkalpak @mhevery
build: check for latest Chromium version (#25602) (#25669)
3bdd4e2 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes #22231

PR Close #25602

PR Close #25669
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this issue Jan 3, 2019
@gkalpak @FrederikSchlemmer
build: check for latest Chromium version (angular#25602)
e543c2f 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes angular#22231

PR Close angular#25602
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project freq1: low type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

build: check for latest Chromium version gkalpak/angular
3 participants
@matsko @IgorMinar @vicb