test(ivy): add missing tests on directive lifecycle hooks #22368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclaval
added
action: review
kara
reviewed
Feb 22, 2018
| elementEnd(); | ||
| } | ||
| Comp.ngComponentDef.h(1, 0); | ||
| componentRefresh(1, 0); |
There was a problem hiding this comment.
It looks like we're missing the directive's hostBindings and refresh here (it was probably missing from the original test too). Same on line 1268.
There was a problem hiding this comment.
Added. I also fixed the original test.
marclaval
force-pushed
the
testLifecycleForDir
branch
from
1dcddc1
to
61880f4
Compare
kara
added
action: merge
smdunn
pushed a commit
to smdunn/angular
that referenced
this pull request
Feb 28, 2018
leo6104
pushed a commit
to leo6104/angular
that referenced
this pull request
Mar 25, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#22351 confirmed that these hooks should called for directives. This PR adds tests to show that.