fix(ivy): Content and View hooks are component-only #22351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marclaval
added
action: review
|
Violating #10221 (comment) ? |
kara
requested changes
Feb 21, 2018
| expect(events).toEqual(['comp']); | ||
| }); | ||
|
|
||
| it('should not be called on directives on an element', () => { |
There was a problem hiding this comment.
This does not match current Angular behavior. Directives on an element or a component will still call content hooks.
| expect(events).toEqual(['comp']); | ||
| }); | ||
|
|
||
| it('should not be called on directives on an element', () => { |
There was a problem hiding this comment.
This does not match current Angular behavior. Directives on elements and components both call view hooks.
|
Discussed with @Mlaval offline, closing |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this issue while adding more directives' hooks tests