Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add HeroService to code tabs and fix headers #22373

Closed
wants to merge 1 commit into from

Conversation

kapunahelewong
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #22359

What is the new behavior?

Adds HeroService to code tabs in Final Code Review.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mary-poppins
Copy link

You can preview 744279e at https://pr22373-744279e.ngbuilds.io/.
You can preview 60389ea at https://pr22373-60389ea.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 69186bc at https://pr22373-69186bc.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 1053568 at https://pr22373-1053568.ngbuilds.io/.

@kapunahelewong
Copy link
Contributor Author

Hey @petebacondarwin could you help me figure out why the page I've edited won't render? https://pr22373-1053568.ngbuilds.io/tutorial/toh-pt5 Maybe some spacing is off?

@jenniferfell
Copy link
Contributor

Master/Detail Components and Routing aren't loading right now. Blank pages. @petebacondarwin do you have any ideas? I've checked routing line-for-line, and I don't recognize anything that would break it. Thanks!

Copy link
Contributor

@jenniferfell jenniferfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Master/Detail Components and Routing aren't loading. Blank pages.

@gkalpak
Copy link
Member

gkalpak commented Mar 1, 2018

This is a known issue #22493. Will be fixed by #22504 (which is marked for merge). Make sure to rebase on master once that's merged.

@ralshammrei2
Copy link

add HeroService to code tabs and fix headers #22373

@mary-poppins
Copy link

You can preview 7e0734e at https://pr22373-7e0734e.ngbuilds.io/.

@kapunahelewong
Copy link
Contributor Author

Hey @jenniferfell want to take a look? Rebased after #22504 was merged.

@gkalpak gkalpak dismissed jenniferfell’s stale review March 7, 2018 22:51

The failures were unrelated to this PR and have been fixed.

@gkalpak gkalpak added the action: merge The PR is ready for merge by the caretaker label Mar 7, 2018
This was referenced Mar 15, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@kapunahelewong kapunahelewong deleted the tohpt5-fix branch June 20, 2019 18:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker aio: preview cla: yes effort1: hours freq3: high target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants