New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add HeroService to code tabs and fix headers #22373
Conversation
744279e
to
60389ea
Compare
You can preview 744279e at https://pr22373-744279e.ngbuilds.io/. |
60389ea
to
69186bc
Compare
You can preview 69186bc at https://pr22373-69186bc.ngbuilds.io/. |
69186bc
to
1053568
Compare
You can preview 1053568 at https://pr22373-1053568.ngbuilds.io/. |
Hey @petebacondarwin could you help me figure out why the page I've edited won't render? https://pr22373-1053568.ngbuilds.io/tutorial/toh-pt5 Maybe some spacing is off? |
Master/Detail Components and Routing aren't loading right now. Blank pages. @petebacondarwin do you have any ideas? I've checked routing line-for-line, and I don't recognize anything that would break it. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Master/Detail Components and Routing aren't loading. Blank pages.
add HeroService to code tabs and fix headers #22373 |
1053568
to
7e0734e
Compare
You can preview 7e0734e at https://pr22373-7e0734e.ngbuilds.io/. |
Hey @jenniferfell want to take a look? Rebased after #22504 was merged. |
The failures were unrelated to this PR and have been fixed.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #22359
What is the new behavior?
Adds
HeroService
to code tabs in Final Code Review.Does this PR introduce a breaking change?
Other information