Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error #22493

Closed
dariolongo opened this issue Feb 28, 2018 · 7 comments
Closed

Documentation error #22493

dariolongo opened this issue Feb 28, 2018 · 7 comments
Assignees
Milestone

Comments

@dariolongo
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[x] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Empty content.

ERROR [DocViewer] Error preparing document 'tutorial/toh-pt3': Error: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Expected behavior

Show Master/Detail Components Chapter

Minimal reproduction of the problem with instructions

Browse to https://next.angular.io/tutorial/toh-pt3

@dariolongo
Copy link
Author

PS: here https://angular.io/tutorial/toh-pt3 works

@ngbot ngbot bot added this to the needsTriage milestone Feb 28, 2018
@petebacondarwin petebacondarwin self-assigned this Feb 28, 2018
@petebacondarwin
Copy link
Member

We have been making doc-gen infrastructure changes on master, which is deployed to next.angular.io. So this is a real bug. Thanks for the catch @dariolongo

@petebacondarwin
Copy link
Member

Well this doesn't make sense to me...

screen shot 2018-02-28 at 22 26 42

@petebacondarwin
Copy link
Member

The anchorLink has just been selected from the a and now we are trying to remove it. How can it not be a child?

Unless... it is a descendant but not a child.

@petebacondarwin
Copy link
Member

Ahah! This is because the querySelector is finding a code-anchor a tag before it finds the header-link a tag.
We need to change the selector to be more specific.

petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Feb 28, 2018
The previous approach just removed the first `a` tag that
was found, but now that the header-link anchor is not at
the start of the heading, it could fail.

Closes angular#22493
@petebacondarwin
Copy link
Member

Fix is in the pipeline :-)

@petebacondarwin petebacondarwin added this to REVIEW in docs-infra Feb 28, 2018
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Mar 1, 2018
The previous approach just removed the first `a` tag that
was found, but now that the header-link anchor is not at
the start of the heading, it could fail.

Closes angular#22493
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Mar 1, 2018
The previous approach just removed the first `a` tag that
was found, but now that the header-link anchor is not at
the start of the heading, it could fail.

Closes angular#22493
@petebacondarwin petebacondarwin moved this from REVIEW to MERGE in docs-infra Mar 1, 2018
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Mar 1, 2018
The previous approach just removed the first `a` tag that
was found, but now that the header-link anchor is not at
the start of the heading, it could fail.

Closes angular#22493
@petebacondarwin petebacondarwin removed this from MERGE in docs-infra Mar 5, 2018
leo6104 pushed a commit to leo6104/angular that referenced this issue Mar 25, 2018
The previous approach just removed the first `a` tag that
was found, but now that the header-link anchor is not at
the start of the heading, it could fail.

Closes angular#22493

PR Close angular#22533
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.