feat(compiler-cli): add support to extend `angularCompilerOptions` #22717

alan-agius4 · 2018-03-12T18:24:41Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

TypeScript only supports merging and extending of compilerOptions.

Issue Number: #22684

What is the new behavior?

This is an implementation to support extending and inheriting of angularCompilerOptions from multiple files.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

packages/compiler-cli/test/BUILD.bazel

alan-agius4 · 2018-04-15T09:33:06Z

//cc @chuckjaz & @mhevery

alan-agius4 · 2018-07-29T19:33:46Z

Bump @vicb and @alxhub

alxhub · 2018-08-09T16:53:00Z

packages/compiler-cli/test/perform_compile_spec.ts

+    basePath = support.basePath;
+  });
+
+  function writeSomeRoutes() {


writeSomeConfigs?

Yes better, updated.

alan-agius4 · 2018-08-09T18:41:20Z

Travis error looks to be a flake.

IgorMinar

Can we please add a documentation for this change? we shouldn't merge new features like this without docs. thanks!

the current compiler options are documented here: aio/content/guide/aot-compiler.md

alan-agius4 · 2018-08-14T21:09:21Z

@IgorMinar, I have added the requested docs. Can you please review them?

Please feel free to suggest or do any changes.

Ps: I have also rebased and thanks for your review.

alan-agius4 · 2018-08-14T22:22:15Z

The Travis failure is a flake.

benlesh · 2018-08-14T23:42:02Z

@alan-agius4 or @IgorMinar ... flag this as PR action: merge when you're done with your review process, please. I'll keep an eye out.

benlesh · 2018-08-14T23:44:09Z

For googlers: presubmit (attn: @IgorMinar)

alan-agius4 · 2018-08-20T13:28:37Z

@IgorMinar, do you mind re-checking this please? Thanks.

alexeagle · 2018-09-07T14:28:02Z

packages/compiler-cli/src/perform_compile.ts

@@ -128,7 +128,37 @@ export function readConfiguration(
  try {
    const {projectFile, basePath} = calcProjectFileAndBasePath(project);

-    let {config, error} = ts.readConfigFile(projectFile, ts.sys.readFile);
+    const readExtendedConfigFile =
+        (configFile: string, existingConfig?: any): {config?: any; error?: ts.Diagnostic;} => {


I think we prefer to comma-separate

packages/compiler-cli/test/BUILD.bazel

packages/compiler-cli/src/perform_compile.ts

hasn't replied in 18d

mary-poppins · 2018-09-07T18:33:49Z

jenniferfell · 2018-09-07T18:55:46Z

@alan-agius4 Thanks. We've been working on a related doc PR that is also about ready to merge. It contains some improvements to the order of sections within the AOT doc: #22353

I think things will merge more seamlessly if we land 22353 first. I've ask the author to accelerate and she should be done with final changes by EOD today.

Meanwhile, I'll take a look at your new section with an eye toward where it will fit best in the new structure and do a quick copy edit.

Will that work for you?

alan-agius4 · 2018-09-07T20:04:54Z

Yes, that will work.

…

On Fri, 07 Sep 2018 at 21:02, Jennifer Fell ***@***.***> wrote: @alan-agius4 <https://github.com/alan-agius4> Thanks. We've been working on a related doc PR that is also about ready to merge. It contains some improvements to the order of sections within the AOT doc: #22353 <#22353> I think things will merge more seamlessly if we land 22353 first. I've ask the author to accelerate and she should be done with final changes by EOD today. Meanwhile, I'll take a look at your new section with an eye toward where it will fit best in the new structure and do a quick copy edit. Will that work for you? — You are receiving this because you were mentioned. Reply to this email directly, view it orn GitHub <#22717 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQv-Wkt5OEdPQ8bIg_eYHWlZKUsrvowvks5uYsKxgaJpZM4SnJm5> .

mary-poppins · 2018-09-10T18:03:28Z

You can preview ab8f729 at https://pr22717-ab8f729.ngbuilds.io/.

mary-poppins · 2018-09-10T18:07:29Z

You can preview 70a5519 at https://pr22717-70a5519.ngbuilds.io/.

mary-poppins · 2018-09-10T19:12:18Z

You can preview 3f594fa at https://pr22717-3f594fa.ngbuilds.io/.

mary-poppins · 2018-09-11T06:11:10Z

You can preview 4f79913 at https://pr22717-4f79913.ngbuilds.io/.

`TypeScript` only supports merging and extending of `compilerOptions`. This is an implementation to support extending and inheriting of `angularCompilerOptions` from multiple files. Closes: #22684

mary-poppins · 2018-09-11T07:46:02Z

You can preview 6c5ce1f at https://pr22717-6c5ce1f.ngbuilds.io/.

alan-agius4 · 2018-09-11T09:09:23Z

@jenniferfell CI is all green here as well

IgorMinar

thanks for updating the pr

IgorMinar · 2018-09-19T18:57:50Z

http://test/OCL:213668215:BASE:213668331:1537383459910:513bda2c

…ngular#22717) `TypeScript` only supports merging and extending of `compilerOptions`. This is an implementation to support extending and inheriting of `angularCompilerOptions` from multiple files. Closes: angular#22684 PR Close angular#22717

angular-automatic-lock-bot · 2019-09-14T01:52:23Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Mar 12, 2018

kara added the area: core Issues related to the framework runtime label Mar 12, 2018

alan-agius4 commented Apr 15, 2018

View reviewed changes

packages/compiler-cli/test/BUILD.bazel Show resolved Hide resolved

alxhub approved these changes Aug 9, 2018

View reviewed changes

mhevery added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Aug 9, 2018

IgorMinar previously requested changes Aug 14, 2018

View reviewed changes

benlesh removed the action: merge The PR is ready for merge by the caretaker label Aug 14, 2018

alexeagle approved these changes Sep 7, 2018

View reviewed changes

jenniferfell added comp: docs aio: preview labels Sep 7, 2018

feat(compiler-cli): add support to extend angularCompilerOptions

6c5ce1f

`TypeScript` only supports merging and extending of `compilerOptions`. This is an implementation to support extending and inheriting of `angularCompilerOptions` from multiple files. Closes: #22684

jenniferfell approved these changes Sep 17, 2018

View reviewed changes

IgorMinar approved these changes Sep 19, 2018

View reviewed changes

IgorMinar added the action: merge The PR is ready for merge by the caretaker label Sep 19, 2018

kara closed this in d7e5bbf Sep 19, 2018

alan-agius4 deleted the feature/angular-compiler-opts-extends branch September 20, 2018 08:55

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(compiler-cli): add support to extend `angularCompilerOptions` #22717

feat(compiler-cli): add support to extend `angularCompilerOptions` #22717

alan-agius4 commented Mar 12, 2018 •

edited

alan-agius4 commented Apr 15, 2018 •

edited

alan-agius4 commented Jul 29, 2018

alxhub Aug 9, 2018

alan-agius4 Aug 9, 2018

alan-agius4 commented Aug 9, 2018

IgorMinar left a comment •

edited

alan-agius4 commented Aug 14, 2018 •

edited

alan-agius4 commented Aug 14, 2018

benlesh commented Aug 14, 2018

benlesh commented Aug 14, 2018 •

edited

alan-agius4 commented Aug 20, 2018

alexeagle Sep 7, 2018

alan-agius4 Sep 7, 2018

mary-poppins commented Sep 7, 2018

jenniferfell commented Sep 7, 2018

alan-agius4 commented Sep 7, 2018 via email

mary-poppins commented Sep 10, 2018

mary-poppins commented Sep 10, 2018

mary-poppins commented Sep 10, 2018

mary-poppins commented Sep 11, 2018

mary-poppins commented Sep 11, 2018

alan-agius4 commented Sep 11, 2018

IgorMinar left a comment

IgorMinar commented Sep 19, 2018 •

edited

angular-automatic-lock-bot bot commented Sep 14, 2019

feat(compiler-cli): add support to extend angularCompilerOptions #22717

feat(compiler-cli): add support to extend angularCompilerOptions #22717

Conversation

alan-agius4 commented Mar 12, 2018 • edited

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

alan-agius4 commented Apr 15, 2018 • edited

alan-agius4 commented Jul 29, 2018

alxhub Aug 9, 2018

Choose a reason for hiding this comment

alan-agius4 Aug 9, 2018

Choose a reason for hiding this comment

alan-agius4 commented Aug 9, 2018

IgorMinar left a comment • edited

Choose a reason for hiding this comment

alan-agius4 commented Aug 14, 2018 • edited

alan-agius4 commented Aug 14, 2018

benlesh commented Aug 14, 2018

benlesh commented Aug 14, 2018 • edited

alan-agius4 commented Aug 20, 2018

alexeagle Sep 7, 2018

Choose a reason for hiding this comment

alan-agius4 Sep 7, 2018

Choose a reason for hiding this comment

mary-poppins commented Sep 7, 2018

jenniferfell commented Sep 7, 2018

alan-agius4 commented Sep 7, 2018 via email

mary-poppins commented Sep 10, 2018

mary-poppins commented Sep 10, 2018

mary-poppins commented Sep 10, 2018

mary-poppins commented Sep 11, 2018

mary-poppins commented Sep 11, 2018

alan-agius4 commented Sep 11, 2018

IgorMinar left a comment

Choose a reason for hiding this comment

IgorMinar commented Sep 19, 2018 • edited

angular-automatic-lock-bot bot commented Sep 14, 2019

feat(compiler-cli): add support to extend `angularCompilerOptions` #22717

feat(compiler-cli): add support to extend `angularCompilerOptions` #22717

alan-agius4 commented Mar 12, 2018 •

edited

alan-agius4 commented Apr 15, 2018 •

edited

IgorMinar left a comment •

edited

alan-agius4 commented Aug 14, 2018 •

edited

benlesh commented Aug 14, 2018 •

edited

IgorMinar commented Sep 19, 2018 •

edited