Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to rxjs@6.0.0-beta.0 #22887

Closed
wants to merge 5 commits into from
Closed

build: update to rxjs@6.0.0-beta.0 #22887

wants to merge 5 commits into from

Conversation

IgorMinar
Copy link
Contributor

No description provided.

@IgorMinar IgorMinar added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Mar 20, 2018
@mary-poppins
Copy link

You can preview 18d0350 at https://pr22887-18d0350.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 3e68e94 at https://pr22887-3e68e94.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 96b2ab1 at https://pr22887-96b2ab1.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 3dafa3d at https://pr22887-3dafa3d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 0e88ed9 at https://pr22887-0e88ed9.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 8b1d875 at https://pr22887-8b1d875.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 7bcc7ec at https://pr22887-7bcc7ec.ngbuilds.io/.

@IgorMinar
ci: temporarily disable two styleguide example tests
3d26b62 
these tests started failing with 6.0.0-beta.0 upgrade because of a weird issue when used with rxjs v6 with rxjs-compat
@IgorMinar
build: add rxjs patch to make bazel build work with rxjs@6.0.0-beta.0
53cbad0
@IgorMinar
build: update to rxjs@6.0.0-beta.0
8094f67
@mary-poppins
Copy link

You can preview 3ba14e5 at https://pr22887-3ba14e5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 8094f67 at https://pr22887-8094f67.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 14403bf at https://pr22887-14403bf.ngbuilds.io/.

@IgorMinar IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 20, 2018
@IgorMinar IgorMinar closed this in 5f1be9b Mar 20, 2018
IgorMinar added a commit that referenced this pull request Mar 20, 2018
@IgorMinar
build: add rxjs patch to make bazel build work with rxjs@6.0.0-beta.0 (…
fad86a6 
…#22887)

PR Close #22887
IgorMinar added a commit that referenced this pull request Mar 20, 2018
@IgorMinar
build: update to rxjs@6.0.0-beta.0 (#22887)
3cc5c2e 
PR Close #22887
gkalpak
gkalpak reviewed Mar 21, 2018
View reviewed changes
aio/tools/ng-packages-installer/index.js
@@ -169,6 +169,7 @@ class NgPackagesInstaller {
// FIXME: Temporarily use RxJS from root `node_modules/`.
if (peerDependencies.rxjs) {
peerDependencies.rxjs = `file:${ANGULAR_ROOT_DIR}/node_modules/rxjs`;
peerDependencies['rxjs-compat'] = '6.0.0-beta.0';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IgorMinar: Can we get rid of these two with 6.0.0-beta.1?

leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
ci: temporarily disable two styleguide example tests (angular#22887)
8f99dc8 
these tests started failing with 6.0.0-beta.0 upgrade because of a weird issue when used with rxjs v6 with rxjs-compat

PR Close angular#22887
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build: add rxjs patch to make bazel build work with rxjs@6.0.0-beta.0 (…
07ee3aa 
…angular#22887)

PR Close angular#22887
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@IgorMinar @leo6104
build: update to rxjs@6.0.0-beta.0 (angular#22887)
a79a730 
PR Close angular#22887
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak left review comments

@jasonaden jasonaden jasonaden approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@IgorMinar @mary-poppins @jasonaden @gkalpak @googlebot