-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update to rxjs@6.0.0-beta.0 #22887
Conversation
You can preview 18d0350 at https://pr22887-18d0350.ngbuilds.io/. |
You can preview 3e68e94 at https://pr22887-3e68e94.ngbuilds.io/. |
You can preview 96b2ab1 at https://pr22887-96b2ab1.ngbuilds.io/. |
You can preview 3dafa3d at https://pr22887-3dafa3d.ngbuilds.io/. |
You can preview 0e88ed9 at https://pr22887-0e88ed9.ngbuilds.io/. |
You can preview 8b1d875 at https://pr22887-8b1d875.ngbuilds.io/. |
You can preview 7bcc7ec at https://pr22887-7bcc7ec.ngbuilds.io/. |
these tests started failing with 6.0.0-beta.0 upgrade because of a weird issue when used with rxjs v6 with rxjs-compat
3ba14e5
to
8094f67
Compare
You can preview 3ba14e5 at https://pr22887-3ba14e5.ngbuilds.io/. |
You can preview 8094f67 at https://pr22887-8094f67.ngbuilds.io/. |
You can preview 14403bf at https://pr22887-14403bf.ngbuilds.io/. |
@@ -169,6 +169,7 @@ class NgPackagesInstaller { | |||
// FIXME: Temporarily use RxJS from root `node_modules/`. | |||
if (peerDependencies.rxjs) { | |||
peerDependencies.rxjs = `file:${ANGULAR_ROOT_DIR}/node_modules/rxjs`; | |||
peerDependencies['rxjs-compat'] = '6.0.0-beta.0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IgorMinar: Can we get rid of these two with 6.0.0-beta.1
?
these tests started failing with 6.0.0-beta.0 upgrade because of a weird issue when used with rxjs v6 with rxjs-compat PR Close angular#22887
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.