docs: update text around changed obs examples

[jbogarthyde]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
#22890

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

mostly cosmetic changes

[mary-poppins]

You can preview d6628b0 at https://pr22920-d6628b0.ngbuilds.io/.

[jenniferfell]

Minor: Google style uses Oxford comma. "...imports Observable, of, and the delay operator from rxjs."

[jenniferfell]

Example: Please double-check. Looking at hero-list.component.ts, it looks like the import is "finalize" instead of "finally".

[jenniferfell]

@IgorMinar @jasonaden I noticed that most changes are editorial. I just confirmed with @jbogarthyde. "The doc never described the code in enough detail to need alteration. The changes were mostly to how rxjs things are imported -- there was one very minor text change that resulted from that." (in reactive forms doc)

[mary-poppins]

You can preview cdeeb1e at https://pr22920-cdeeb1e.ngbuilds.io/.

[mary-poppins]

You can preview 1fb1304 at https://pr22920-1fb1304.ngbuilds.io/.

[jenniferfell]

@jbogarthyde Thanks for fixing those legacy issues by changing HeroService in text to match the HeroesService we see in the examples. (unrelated to rxjs changes)

@mhevery HTTP and Reactive Forms have content changes related to the examples and rxjs. Other files are just editorial to match style guide or how we refer to observables elsewhere. IMO this is ready to merge. Q: Do you want @jbogarthyde to merge the commits first? Thanks for stepping in!

[jenniferfell]

@mhevery @IgorMinar Hi. Can one of you approve, please...or let us know what we need to do/change before approval? Thanks!

[jenniferfell]

@IgorMinar While you were away, Brad and @mhevery said you need to be the one to review and approve this. Thanks.

[IgorMinar]

looks good.

I'm a bit surprised that no bigger changes were necessary given all the changes that happened to the example code, but I'm not aware of any particular sections that still need an update.

[ngbot]

I see that you just added the PR action: merge label, but the following checks are still failing:
     missing required status "ci/circleci: build"
     missing required status "ci/circleci: lint"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[IgorMinar]

caretaker note: I'm not sure why the circleCI jobs didn't fire on this PR, but the changes in this PR are docs only so it doesn't matter. If we do see other PRs with CI results missing we should investigate.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}