All locales from @angular/common/locales contain extra comma after ['AM', 'PM'] array

[marzecm]

Hi,

I'm importing many locales from @angular/common/locales (en, fr, fr-CA, ...) and I'm getting
Uncaught TypeError: Cannot read property 'visitExpression' of undefined raised by zone.js at runtime.

Current behavior

At runtime zone.js raises an error
Uncaught TypeError: Cannot read property 'visitExpression' of undefined

Expected behavior

Can use locales without errors at runtime.

Personnal investigation

It seems that the reason is that default object being exported from locale file contains 2 extra commas at default[2] which is right after ['AM', 'PM'],,
This extra comma is present in ALL files from @angular/common/locales.

example: https://github.com/angular/angular/blob/master/packages/common/locales/fr.ts at line 21-22 commas should be removed

in english version https://github.com/angular/angular/blob/master/packages/common/locales/en.ts
the extra comma is also present at default[1] at line 22

Can you please clean those files from this extra comma?

[trotyl]

It's by design, [42, ] is equivalent to [42, undefined] but saved many space.

Also it's not undefined in many locales like https://github.com/angular/angular/blob/master/packages/common/locales/br.ts

[guilhermevrs]

Hey
I am having the exact the same error.

I understand what your point @trotyl, so perhaps a fix should be made in the JIT interpreter? (at least on my case, building my app on AoT seems to fix the issue, but I also want to use the JIT)

[trotyl]

Please provide reproduction for any of your problem.

[vicb]

The issue is not with the interpreter: [42, ] and [42, undefined] will work equally well. Without a repro we can not know what is wrong.
However our plan is to change the sparse array and have explicit undefined because it already caused troubles with some webpack plugins

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}