Cyclic dependency in HTTP_INTERCEPTORS when using platform-server

[marcin-j]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

When using platform-server and injecting service which uses HttpClient into HttpInterceptor the cyclic dependency error occurs.

Expected behavior

There shouldn't be any cyclic dependency error.

For platform-browser it was fixed after #18224

Minimal reproduction of the problem with instructions

Create service (DummyService) which uses HttpClient
Create HTTP_INTERCEPTORS interceptor and inject DummyService there

Environment

Angular version: 5.2.3

[MarkPieszak]

Try using the Injector to grab HttpClient, you shouldn't have any issues that way:

get http() {
    return this._injector.get(HttpClient);
  }

constructor(private injector: Injector) { }

// somewhere else
this.http.get();

Hope that helps!

[marcin-j]

Hey, thats what I'm doing for now and it works. I just thought that if it works for platform-browser (no cyclic dependencies) it should work for platform-server as well. Thanks for answer :)

[jaumard]

Still same error with angular 6.0.3, I'll try the injector solution

[Willovent]

I have this error as well on 6.0.3. But my interceptor is not using httpClient.
Here is the code of the interceptor causing the issue on my project :

import { REQUEST } from '@nguniversal/express-engine/tokens';

@Injectable()
export class RefererInterceptor implements HttpInterceptor {
  constructor(@Optional() @Inject(REQUEST) private request) {}

  public intercept(req: HttpRequest<any>, next: HttpHandler): Observable<HttpEvent<any>> {
    if (this.request) {
      const host = `${this.request.protocol}://${this.request.headers.host}`;
      req = req.clone({
        headers: req.headers.append('StSsrReferer', host)
      });
      return next.handle(req);
    }
  }
}

[vikerman]

@Willovent - what's the exact DI exception message. Want to make sure it's the same issue.

[Willovent]

Turn out it was not the interceptor that I linked, but an another one using a service using an httpClient. Sorry for that :(

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}