Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix windows scripts #23121

Closed
wants to merge 1 commit into from
Closed

build: fix windows scripts #23121

wants to merge 1 commit into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Apr 2, 2018

PR Checklist

PR Type

[x] Build related changes

What is the new behavior?

The packages/core/src/animation/dsl.ts symlink ws removed in #22692, so create-/remove-symlinks.sh scripts for Windows should not try to "fix" it.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Follow-up to #22692.

@gkalpak
build: fix windows scripts
62f8967 
The `packages/core/src/animation/dsl.ts` symlink ws removed in angular#22692,
so `create-/remove-symlinks.sh` scripts for Windows should not try to
"fix" it.
@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release labels Apr 2, 2018
@gkalpak gkalpak added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Apr 16, 2018
@alexeagle alexeagle requested a review from matsko May 30, 2018 15:52
alexeagle
alexeagle approved these changes Jul 11, 2018
View reviewed changes
Copy link
Contributor

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matsko I hope this looks right to you?

@alexeagle alexeagle added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 11, 2018
@gkalpak
Copy link
Member Author

gkalpak commented Jul 11, 2018

It does, it does 😁
(This only affects people trying to build on Windows, so other than the 3-4 of us nobody else cares 😁

@matsko matsko closed this in a663565 Jul 12, 2018
matsko pushed a commit that referenced this pull request Jul 12, 2018
@gkalpak @matsko
build: fix windows scripts (#23121)
0e7501b 
The `packages/core/src/animation/dsl.ts` symlink ws removed in #22692,
so `create-/remove-symlinks.sh` scripts for Windows should not try to
"fix" it.

PR Close #23121
@gkalpak gkalpak deleted the build-fix-windows-scripts branch July 12, 2018 23:03
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@matsko matsko matsko approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gkalpak @alexeagle @matsko @googlebot