Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): remove core animation import symbols #22692

Closed
wants to merge 1 commit into from
Closed

fix(core): remove core animation import symbols #22692

wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Mar 9, 2018

This patch removes the deprecated support for animation
symbol imports from @angular/core.

BREAKING CHANGE: it is no longer possible to import
animation-related functions from @angular/core. All
animation symbols must now be imported from @angular/animations.

@matsko matsko requested a review from IgorMinar March 9, 2018 23:56
@matsko matsko added the target: major This PR is targeted for the next major release label Mar 9, 2018
@mary-poppins
Copy link

You can preview 055ed1a at https://pr22692-055ed1a.ngbuilds.io/.

@matsko matsko force-pushed the fix_core_animation_imports branch from 055ed1a to d2747b3 Compare March 12, 2018 16:14
@mary-poppins
Copy link

You can preview d2747b3 at https://pr22692-d2747b3.ngbuilds.io/.

@matsko matsko force-pushed the fix_core_animation_imports branch from d2747b3 to 70ac53d Compare March 12, 2018 16:57
@mary-poppins
Copy link

You can preview 70ac53d at https://pr22692-70ac53d.ngbuilds.io/.

@matsko matsko requested review from mhevery and removed request for IgorMinar March 12, 2018 18:56
mhevery
mhevery approved these changes Mar 12, 2018
View reviewed changes
tools/public_api_guard/core/core.d.ts Outdated
styles: AnimationStyleMetadata | AnimationKeyframesSequenceMetadata | null;
timings: string | number | AnimateTimings;
}

/** @deprecated */
export declare type AnimationEntryMetadata = any;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete these as well. They are coming from core.ts

@matsko matsko force-pushed the fix_core_animation_imports branch from 70ac53d to 48781df Compare March 12, 2018 19:09
@mary-poppins
Copy link

You can preview 48781df at https://pr22692-48781df.ngbuilds.io/.

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Mar 12, 2018
@ngbot
Copy link

ngbot bot commented Mar 12, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    pending status "google3" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ngbot
Copy link

ngbot bot commented Mar 13, 2018

Hi @matsko! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@matsko matsko force-pushed the fix_core_animation_imports branch from 48781df to 80d6851 Compare March 13, 2018 19:37
@matsko
fix(core): remove core animation import symbols
4ed71c4 
This patch removes the deprecated support for animation
symbol imports from @angular/core.

BREAKING CHANGE: it is no longer possible to import
animation-related functions from @angular/core. All
animation symbols must now be imported from @angular/animations.
@matsko matsko force-pushed the fix_core_animation_imports branch from 80d6851 to 4ed71c4 Compare March 13, 2018 19:44
@mary-poppins
Copy link

You can preview 80d6851 at https://pr22692-80d6851.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4ed71c4 at https://pr22692-4ed71c4.ngbuilds.io/.

@kara kara added action: merge The PR is ready for merge by the caretaker and removed action: merge The PR is ready for merge by the caretaker labels Mar 14, 2018
@kara kara closed this in f5a98f4 Mar 14, 2018
@matsko matsko deleted the fix_core_animation_imports branch March 14, 2018 19:26
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@matsko @leo6104
fix(core): remove core animation import symbols (angular#22692)
fd83f32 
This patch removes the deprecated support for animation
symbol imports from @angular/core.

BREAKING CHANGE: it is no longer possible to import
animation-related functions from @angular/core. All
animation symbols must now be imported from @angular/animations.

PR Close angular#22692
gkalpak added a commit to gkalpak/angular that referenced this pull request Apr 2, 2018
@gkalpak
build: fix windows scripts
62f8967 
The `packages/core/src/animation/dsl.ts` symlink ws removed in angular#22692,
so `create-/remove-symlinks.sh` scripts for Windows should not try to
"fix" it.
@gkalpak gkalpak mentioned this pull request Apr 2, 2018
Closed
3 tasks
matsko pushed a commit that referenced this pull request Jul 12, 2018
@gkalpak @matsko
build: fix windows scripts (#23121)
a663565 
The `packages/core/src/animation/dsl.ts` symlink ws removed in #22692,
so `create-/remove-symlinks.sh` scripts for Windows should not try to
"fix" it.

PR Close #23121
matsko pushed a commit that referenced this pull request Jul 12, 2018
@gkalpak @matsko
build: fix windows scripts (#23121)
0e7501b 
The `packages/core/src/animation/dsl.ts` symlink ws removed in #22692,
so `create-/remove-symlinks.sh` scripts for Windows should not try to
"fix" it.

PR Close #23121
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhevery mhevery mhevery approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: animations cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@matsko @mary-poppins @mhevery @kara @googlebot