Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: invalid nav items #23175

Closed
wants to merge 2 commits into from
Closed

aio: invalid nav items #23175

wants to merge 2 commits into from

Conversation

petebacondarwin
Copy link
Member

No description provided.

@petebacondarwin
build(aio): fail the doc-gen if the nav is invalid
01e9c47
@petebacondarwin
docs(aio): remove invalid nav item
eba6ef6 
The `custom-elements` guide page was renamed to `elements` in ff34d5e.
That commit also added a new nav item for the renamed file, so this item is
no longer valid.
@petebacondarwin petebacondarwin added action: review The PR is still awaiting reviews from at least one requested reviewer comp: aio target: major This PR is targeted for the next major release labels Apr 4, 2018
@petebacondarwin petebacondarwin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 4, 2018
@alxhub alxhub closed this in 5b6e59c Apr 4, 2018
alxhub pushed a commit that referenced this pull request Apr 4, 2018
@petebacondarwin @alxhub
docs(aio): remove invalid nav item (#23175)
6dd8f6e 
The `custom-elements` guide page was renamed to `elements` in ff34d5e.
That commit also added a new nav item for the renamed file, so this item is
no longer valid.

PR Close #23175
@jenniferfell jenniferfell mentioned this pull request Apr 5, 2018
Closed
2 tasks
@petebacondarwin petebacondarwin deleted the aio-invalid-nav-items branch April 5, 2018 16:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@petebacondarwin @gkalpak @googlebot