Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove old elements item from navigation #23173

Closed

Conversation

jenniferfell
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[X ] Other... Please describe: Docs navigation change

What is the current behavior?

There is an extra old "Custom Elements" item in the navigation, with no associated file. This change removes that old entry. (new nav entry was in the elements doc PR)

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@jenniferfell jenniferfell added target: major This PR is targeted for the next major release comp: docs labels Apr 4, 2018
@jenniferfell
Copy link
Contributor Author

PR #22966 added a new custom element item to the nav, with the new doc associated. It removed a page of old doc, but it failed to remove the old nav item. This PR removes that old nav item.

@jenniferfell
Copy link
Contributor Author

Fixed by #23175

@jenniferfell jenniferfell deleted the jfell-navigation-elements branch April 5, 2018 05:16
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants