Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem in bundles with Angular 6.0.0-rc.4 #23343

Closed
uparlange opened this issue Apr 12, 2018 · 3 comments
Closed

Problem in bundles with Angular 6.0.0-rc.4 #23343

uparlange opened this issue Apr 12, 2018 · 3 comments
Labels
area: bazel Issues related to the published `@angular/bazel` build rules regression Indicates than the issue relates to something that worked in a previous version

Comments

@uparlange
Copy link

I'm submitting a...


[x ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

Unable to load my application

Expected behavior

Bundles should work as expected

Minimal reproduction of the problem with instructions

Angular 6.0.0-rc.0 --> OK
https://unpkg.com/@angular/compiler@6.0.0-rc.0/bundles/compiler.umd.js
(factory((global.ng = global.ng || {}, global.ng.compiler = {})));

Angular 6.0.0-rc.4 --> KO
https://unpkg.com/@angular/compiler@6.0.0-rc.4/bundles/compiler.umd.js
(factory((global.npm_package = {}),global.tslib,global.rxjs,global.rxjs.operators));

What is the motivation / use case for changing the behavior?

Bundles should work as expected

Environment


Angular version: 6.0.0-rc.4

Browser: ALL

@uparlange
Copy link
Author

uparlange commented Apr 12, 2018

I had this problem many times in older versions. Isn't possible to have a simple web page loading all bundles and make sure everything is ok before releasing a version ?

@jasonaden jasonaden added the area: bazel Issues related to the published `@angular/bazel` build rules label Apr 12, 2018
@ngbot ngbot bot added this to the needsTriage milestone Apr 12, 2018
@jasonaden jasonaden added the regression Indicates than the issue relates to something that worked in a previous version label Apr 12, 2018
@jasonaden jasonaden modified the milestones: needsTriage, v6.0 Apr 12, 2018
@alexeagle
Copy link
Contributor

@uparlange yes, our integration tests haven't been ported to run against the bazel-produced packages so we are clearly pushing releases without proper testing. Working to fix that now, thanks for being our human quality control in the gap...

alexeagle added a commit to alexeagle/angular that referenced this issue Apr 12, 2018
alexeagle added a commit to alexeagle/angular that referenced this issue Apr 12, 2018
wKoza pushed a commit to wKoza/angular that referenced this issue Apr 13, 2018
wKoza pushed a commit to wKoza/angular that referenced this issue Apr 13, 2018
wKoza pushed a commit to wKoza/angular that referenced this issue Apr 13, 2018
alexeagle added a commit to alexeagle/angular that referenced this issue Apr 13, 2018
Also include tslib in the bundles rather than mark it external.

Fixes angular#23343
Fixes angular#22971
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: bazel Issues related to the published `@angular/bazel` build rules regression Indicates than the issue relates to something that worked in a previous version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants