Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations freeze in safari when using ng serve --prod #23401

Closed
andrewseguin opened this issue Apr 16, 2018 · 2 comments
Closed

Animations freeze in safari when using ng serve --prod #23401

andrewseguin opened this issue Apr 16, 2018 · 2 comments
Assignees

Comments

@andrewseguin
Copy link
Contributor

andrewseguin commented Apr 16, 2018

I'm submitting a...


[x] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

Safari freezes when performing an animation in an app built with ng build --prod

Expected behavior

Shouldn't freeze

Minimal reproduction of the problem with instructions

https://github.com/andrewseguin/broken-animations
Here's a repo that can be run with ng serve --prod. When the red div is clicked, an animation plays to change it to green. In Safari, this freezes the browser.

Environment


Angular version: 6.0.0-rc.5
CLI: 6.0.0-rc.4

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [x] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
@andrewseguin andrewseguin added this to the v6-candidates milestone Apr 16, 2018
@nielsheeren
Copy link

nielsheeren commented Apr 17, 2018

I have the same issue with ng build --prod in combination with IE11 and Edge. A development build doesn't freeze those browsers.

matsko added a commit to matsko/angular that referenced this issue Apr 17, 2018
This patch is in response to angular#23401 where a non-const enum was being
compiled as an empty object when used in an animation player when
`ng build --prod` was being processed. This patch is a immediate fix
for the issue and angular#23400 tracks it.

Closes angular#23401
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants