Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(animations): use a const enum to avoid compilation side effects #23402

Closed
wants to merge 1 commit into from
Closed

refactor(animations): use a const enum to avoid compilation side effects #23402

wants to merge 1 commit into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Apr 16, 2018

This patch is in response to #23400

@mary-poppins
Copy link

You can preview 7cab7ba at https://pr23402-7cab7ba.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e175cbc at https://pr23402-e175cbc.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes Apr 16, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - assuming CI passes - can you add a description from your email into the commit message or the source code where const enum is declared?

can you think about how to prevent these issues in the future? do we need linting rule or something in build optimizer to do that. please file a feature request.

@IgorMinar IgorMinar added target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 16, 2018
@matsko
refactor(animations): use a const enum to avoid compilation side effects
ce36d1f 
This patch is in response to angular#23401 where a non-const enum was being
compiled as an empty object when used in an animation player when
`ng build --prod` was being processed. This patch is a immediate fix
for the issue and angular#23400 tracks it.

Closes angular#23401
@matsko matsko added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Apr 17, 2018
@mary-poppins
Copy link

You can preview ce36d1f at https://pr23402-ce36d1f.ngbuilds.io/.

@jasonaden jasonaden closed this in 7be7abd Apr 17, 2018
@matsko matsko deleted the const_enum_animations branch January 17, 2019 19:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matsko @mary-poppins @IgorMinar @googlebot