MinLength Validator treats zero value as zero length

[gtranter]

angular/packages/forms/src/validators.ts

Line 140 in 0cb4f12

const length: number = control.value ? control.value.length : 0;

The statement const length: number = control.value ? control.value.length : 0; clearly returns zero for length if the value is zero. For numeric inputs, this is a problem.

[EmaGht]

Why would you need a min length of 0? Isn't it the same as not having a MinLength Validator in the first place?

[gtranter]

It's the value that is 0, not the min length. If the min length is 1, and the value is 0, the length is reported as 0 when it should be 1, and validation fails.

Its not really a big problem since min length 1 is the same as required. But the logic is wrong.

[adico1]

I would like to fix that issue.

[ShaneMcGowan]

Having this issue with reactive forms in Angular 5

If passing the value 0 to a form control with a validator of Validators.minLength(1), the form is invalid even though the value 0 should satisfy this minimum length as it is a character

[gtranter]

@ShaneMcGowan I recommend you use Validators.required instead of Validators.minLength(1) as it is functionally equivalent and works properly.

[ShaneMcGowan]

@gtranter Thanks, realised that after a short while and felt a bit silly, but still feel this issue should be fixed as it is quite odd behavior

[AndrewKushnir]

Thanks for reporting this issue @gtranter. This issue is also discussed in #35591, so I'm closing this ticket as a duplicate of #35591. Please subscribe to the #35591 to receive further updates. Thank you.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}