Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router is not propagating exceptions on navigation #2391

Closed
jbdeboer opened this issue Jun 6, 2015 · 2 comments
Closed

Router is not propagating exceptions on navigation #2391

jbdeboer opened this issue Jun 6, 2015 · 2 comments
Assignees
@btford
Labels
effort1: hours type: bug/fix
Milestone
alpha-27

Comments

@jbdeboer
Copy link

jbdeboer commented Jun 6, 2015

To reproduce, see https://github.com/jbdeboer/angular2_router_eating_stack_traces

This demo has a component which throws an exception in its constructor. When the component is created, that exception is not displayed in the Chrome DevTools console. It should be.
@jbdeboer jbdeboer mentioned this issue Jun 6, 2015
Closed
@naomiblack naomiblack added this to the alpha-28 milestone Jun 8, 2015
@btford
Copy link
Contributor

btford commented Jun 8, 2015

On it. Thanks, @jbdeboer!

btford added a commit to btford/angular that referenced this issue Jun 13, 2015
@btford
fix(router): rethrow exceptions
ba0d9cb 
Closes angular#2391
@btford btford mentioned this issue Jun 13, 2015
Closed
btford added a commit to btford/angular that referenced this issue Jun 13, 2015
@btford
fix(router): rethrow exceptions
c01fbc8 
Closes angular#2391
btford added a commit to btford/angular that referenced this issue Jun 13, 2015
@btford
fix(router): rethrow exceptions
b23282f 
Closes angular#2391
@btford btford closed this as completed in 5782f06 Jun 13, 2015
goderbauer pushed a commit to goderbauer/angular that referenced this issue Jun 15, 2015
@btford @goderbauer
fix(router): rethrow exceptions
9afddc8 
Closes angular#2391
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@btford btford

Labels
effort1: hours type: bug/fix
Projects
None yet
Milestone
alpha-27
Development

Successfully merging a pull request may close this issue.

fix(router): rethrow exceptions btford/angular
5 participants
@mhevery @btford @jbdeboer @tbosch @naomiblack