-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When template has an error, it breaks most of the page #2413
Comments
@vicb is this still the case or should we close this issue? |
Not sure, did you mean to ask @vsavkin ? |
IMO still an issue, we had a report of it recently in #9212. Here is a plunker to reproduce: https://plnkr.co/edit/iHDYpZ3fDlO6bhOtlTbQ?p=preview |
Seems like the exception reporter is called but it continues working |
@vicb In the plnkr you linked, yes the exception is thrown but only thrown once. i.e repeatedly clicking |
Same here. I encounter this throughout my app, even with a custom errorHandler. Some parts of the view (not all) will stop updating. |
As I understand all happens in On On |
And exception is thrown every time on clicking the button |
We would love to see this fixed - either through a less brutal built-in strategy or by allowing a custom ErrorHandler to implement a more lenient strategy. As it stands right now, any error thrown in a page makes the page unresponsive and forces the user to reload to resume his work. |
- prevents unsubscribing from the zone on error - prevents unsubscribing from directive `EventEmitter`s on error - prevents detaching views in dev mode if there on error - ensures that `ngOnInit` is only called 1x (also in prod mode) Fixes angular#9531 Fixes angular#2413 Fixes angular#15925
- prevents unsubscribing from the zone on error - prevents unsubscribing from directive `EventEmitter`s on error - prevents detaching views in dev mode if there on error - ensures that `ngOnInit` is only called 1x (also in prod mode) Fixes angular#9531 Fixes angular#2413 Fixes angular#15925
- prevents unsubscribing from the zone on error - prevents unsubscribing from directive `EventEmitter`s on error - prevents detaching views in dev mode if there on error - ensures that `ngOnInit` is only called 1x (also in prod mode) Fixes angular#9531 Fixes angular#2413 Fixes angular#15925
- prevents unsubscribing from the zone on error - prevents unsubscribing from directive `EventEmitter`s on error - prevents detaching views in dev mode if there on error - ensures that `ngOnInit` is only called 1x (also in prod mode) Fixes angular#9531 Fixes angular#2413 Fixes angular#15925
I'm on Angular 7 and just came across this. My template throws an error from referencing a non-existent property, it's caught in the global error handler, but the UI stops working. I am mostly using angular material components so maybe it's an issue there. https://stackblitz.com/edit/template-error-breaks-ui is a stackblitz reproducing the issue. Click the first panel, notice it doesn't fully open. Click the second panel and it also doesn't fully open. If you click the second panel first, it will fully open. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
When there is an error in the template, the CD stops and breaks the remainder of the page. Instead we should just publish the error and continue on processing the remainder of the page.
The text was updated successfully, but these errors were encountered: