Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http): implement support for headers and url params objects in http #2417

Closed
jeffbcross opened this issue Jun 8, 2015 · 3 comments
Closed

feat(http): implement support for headers and url params objects in http #2417

jeffbcross opened this issue Jun 8, 2015 · 3 comments
Assignees
@caitp
Labels
effort1: hours feature Issue that requests a new feature
Milestone
alpha-35

Comments

@jeffbcross
Copy link
Contributor

The constructors for Headers and UrlSearchParams have already been implemented to near-spec (Headers, UrlSearchParams) in PR #2360, but have not been incorporated into the request process. These should be incorporated in such a way that a dictionary or fully-constructed object of each type can be attached to request options passed to http, and will properly be attached to the outgoing request (headers), or serialized into the url string (params).
@jeffbcross jeffbcross added feature Issue that requests a new feature comp: data-access labels Jun 8, 2015
@jeffbcross jeffbcross self-assigned this Jun 8, 2015
@jeffbcross jeffbcross added this to the M10 milestone Jun 8, 2015
@jeffbcross jeffbcross mentioned this issue Jun 9, 2015
Closed
@jeffbcross jeffbcross changed the title Implement support for headers and url params objects in http feat(http): implement support for headers and url params objects in http Jun 9, 2015
@mhevery mhevery modified the milestones: alpha-28, alpha-27 Jun 12, 2015
@jeffbcross jeffbcross modified the milestones: alpha-29, alpha-28 Jun 19, 2015
@jeffbcross jeffbcross removed this from the alpha-29 milestone Jun 30, 2015
@jeffbcross jeffbcross removed their assignment Jun 30, 2015
@jeffbcross jeffbcross mentioned this issue Jun 30, 2015
Closed
35 tasks
@caitp
Copy link
Contributor

caitp commented Jul 2, 2015

I'd like to take this one on as well, but if someone wants this they can take it

@caitp caitp added this to the alpha-31 milestone Jul 2, 2015
@caitp caitp self-assigned this Jul 2, 2015
@jeffbcross
Copy link
Contributor Author

@caitp FYI basic headers setting has been implemented in xhr_backend with #2828, but there's still work to be done in the RequestOptions merging process.

@caitp caitp mentioned this issue Jul 13, 2015
Closed
@jeffbcross jeffbcross modified the milestones: alpha-31, alpha-32 Jul 15, 2015
@naomiblack naomiblack modified the milestones: alpha-32, alpha-33 Jul 23, 2015
@naomiblack naomiblack modified the milestone: alpha-33 Jul 27, 2015
@naomiblack naomiblack added this to the alpha-35 milestone Aug 6, 2015
caitp added a commit to caitp/angular that referenced this issue Aug 10, 2015
@caitp
feat(http): serialize search parameters from request options
02d9799 
- Extends URLSearchParams API to include operations for combining
  different URLSearchParams objects:

  These new methods include:
  setAll(otherParams): performs `this.set(key, values[0])` for each
      key/value-list pair in `otherParams`

  appendAll(otherParams): performs `this.append(key, values)` for
      each key/value-list pair in `otherParams`

  replaceAll(otherParams): for each key/value-list pair in
      `otherParams`, replaces current set of values for `key` with
      a copy of the list of values.

- RequestOptions do not merge search params automatically (because
  there are multiple ways to do this). Instead, they replace any
  existing `search` field if `search` is provided. Explicit merging
  is required if merging is desirable.

- Some extra test coverage added.

Closes angular#2417
caitp added a commit that referenced this issue Aug 10, 2015
@caitp
feat(http): serialize search parameters from request options
1e74aa8 
- Extends URLSearchParams API to include operations for combining
  different URLSearchParams objects:

  These new methods include:
  setAll(otherParams): performs `this.set(key, values[0])` for each
      key/value-list pair in `otherParams`

  appendAll(otherParams): performs `this.append(key, values)` for
      each key/value-list pair in `otherParams`

  replaceAll(otherParams): for each key/value-list pair in
      `otherParams`, replaces current set of values for `key` with
      a copy of the list of values.

- RequestOptions do not merge search params automatically (because
  there are multiple ways to do this). Instead, they replace any
  existing `search` field if `search` is provided. Explicit merging
  is required if merging is desirable.

- Some extra test coverage added.

Closes #2417
@caitp caitp closed this as completed in 77d3668 Aug 10, 2015
goderbauer pushed a commit to goderbauer/angular that referenced this issue Aug 15, 2015
@caitp @goderbauer
feat(http): serialize search parameters from request options
61cc341 
- Extends URLSearchParams API to include operations for combining
  different URLSearchParams objects:

  These new methods include:
  setAll(otherParams): performs `this.set(key, values[0])` for each
      key/value-list pair in `otherParams`

  appendAll(otherParams): performs `this.append(key, values)` for
      each key/value-list pair in `otherParams`

  replaceAll(otherParams): for each key/value-list pair in
      `otherParams`, replaces current set of values for `key` with
      a copy of the list of values.

- RequestOptions do not merge search params automatically (because
  there are multiple ways to do this). Instead, they replace any
  existing `search` field if `search` is provided. Explicit merging
  is required if merging is desirable.

- Some extra test coverage added.

Closes angular#2417
Closes angular#3020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caitp caitp

Labels
effort1: hours feature Issue that requests a new feature
Projects
None yet
Milestone
alpha-35
Development

Successfully merging a pull request may close this issue.

feat(http): serialize search parameters from request options caitp/angular
4 participants
@mhevery @jeffbcross @naomiblack @caitp