Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoBootstrap interface does not exist #24557

Closed
RoopeHakulinen opened this issue Jun 18, 2018 · 4 comments
Closed

DoBootstrap interface does not exist #24557

RoopeHakulinen opened this issue Jun 18, 2018 · 4 comments
Labels
area: core Issues related to the framework runtime feature Issue that requests a new feature
Milestone

Comments

@RoopeHakulinen
Copy link
Contributor

RoopeHakulinen commented Jun 18, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

There is no DoBootstrap interface for modules like there is for all of the lifecycle hooks of components.
capture

Expected behavior

There should be an interface so that this would work:
capture2

What is the motivation / use case for changing the behavior?

There is an interface available for each lifecycle hook but ngDoBootstrap is missing the corresponding interface. This can be problematic for people with OCD over things like shown in the images above.

While adding the interface and getting rid of the linter warning improves quality of my life substantially already, there is also another point: documentation. Currently there is not much documentation covering the ngDoBootstrap so adding the interface also provides an entry for it in the angular.io documentation with example on how it should be utilized.

@RoopeHakulinen
Copy link
Contributor Author

I'll submit a PR soon for this.

@jasonaden jasonaden added the area: core Issues related to the framework runtime label Jun 21, 2018
@ngbot ngbot bot added this to the needsTriage milestone Jun 21, 2018
@mhevery
Copy link
Contributor

mhevery commented Jun 28, 2018

+1 for PR

@mhevery mhevery added the feature Issue that requests a new feature label Jun 28, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jun 28, 2018
@RoopeHakulinen
Copy link
Contributor Author

The PR #24558 should is ready for review @mhevery :)

@kara kara closed this as completed in 732026c Aug 7, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this issue Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: core Issues related to the framework runtime feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants