New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoBootstrap interface does not exist #24557

Closed
RoopeHakulinen opened this Issue Jun 18, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@RoopeHakulinen
Contributor

RoopeHakulinen commented Jun 18, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[x] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
[ ] Other... Please describe:

Current behavior

There is no DoBootstrap interface for modules like there is for all of the lifecycle hooks of components.
capture

Expected behavior

There should be an interface so that this would work:
capture2

What is the motivation / use case for changing the behavior?

There is an interface available for each lifecycle hook but ngDoBootstrap is missing the corresponding interface. This can be problematic for people with OCD over things like shown in the images above.

While adding the interface and getting rid of the linter warning improves quality of my life substantially already, there is also another point: documentation. Currently there is not much documentation covering the ngDoBootstrap so adding the interface also provides an entry for it in the angular.io documentation with example on how it should be utilized.

@RoopeHakulinen

This comment has been minimized.

Contributor

RoopeHakulinen commented Jun 18, 2018

I'll submit a PR soon for this.

@RoopeHakulinen RoopeHakulinen referenced this issue Jun 18, 2018

Closed

feat(core): add DoBootstrap interface. #24558

2 of 3 tasks complete

@ngbot ngbot bot added this to the needsTriage milestone Jun 21, 2018

@mhevery

This comment has been minimized.

Member

mhevery commented Jun 28, 2018

+1 for PR

@ngbot ngbot bot modified the milestones: needsTriage, Backlog Jun 28, 2018

@RoopeHakulinen

This comment has been minimized.

Contributor

RoopeHakulinen commented Jun 29, 2018

The PR #24558 should is ready for review @mhevery :)

@kara kara closed this in 732026c Aug 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment