-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post strictPropertyInitialization flag flip cleanup #24571
Comments
@rkirov when an input is required, would you mark with a band And seeing the comment from @mhevery in #21571 it seems that we are on the same page;
Truth to the told I am not a particular fan of using the |
If you want to have required semantics for your Inputs what we have been recommending is The general advice for I have an additional advice on cleaning up after my change specifically for angular components. For Angular componentsFor angular components, use the following rules in deciding between:
|
Thanks for the detailed explanation much appreciated. I quite like what you suggest above. |
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571
When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See #24571 PR Close #28055
…lar#28055) When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571 PR Close angular#28055
…lar#28055) When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See angular#24571 PR Close angular#28055
…) (#28736) When we added the strict null checks, the lexer had some `!` operators added to prevent the compilation from failing. This commit resolves this problem correctly and removes the hacks. Also the comment ``` // Note: this is always lowercase! ``` has been removed as it is no longer true. See #24571 PR Close #28055 PR Close #28736
Hi, I am fairly new to Github but would like to help out, I see a lot of files that have |
This commit removes the remaining TODO(issue/24571) in elements code base.
This commit removes the remaining TODO(issue/24571) in examples code base.
This commit removes the remaining TODO(issue/24571) in platform-server code base.
As part of angular#24571, removing all non-null assertions from common/http
As part of angular#24571, removing all non-null assertions from common/http
This commit removes the remaining ones in animations code base
This commit removes the remaining TODO(issue/24571) in platform-server code base.
This commit removes the remaining TODO(issue/24571) in platform-server code base.
This commit removes the remaining TODO(issue/24571) in platform-browser code base.
This commit removes the remaining TODO(issue/24571) in platform-browser code base.
This commit removes the remaining TODO(issue/24571) in compiler code base.
This commit removes the remaining TODO(issue/24571) in core code base.
This commit removes the remaining TODO(issue/24571) in core code base.
This commit removes the remaining TODO(issue/24571) in core code base.
This commit removes the remaining TODO(issue/24571) in core code base.
This commit removes the remaining TODO(issue/24571) in core code base. PR Close angular#49221
This commit removes the remaining TODO(issue/24571) in core code base. PR Close angular#49221
I'm submitting a...
[x] Other... Please describe: Tracking issue for internal cleanup.
What needs to be done
In order to quickly turn on strictPropertyInitialization flag in the whole code base, we introduced
!
on every non-initialized class field. Each one of those fields needs to be individually checked and decided whether:foo!: string
, should becomefoo = 'default'
.foo!: string
, should becomefoo?: string
.!
should be kept.The text was updated successfully, but these errors were encountered: