Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transpiler: Improve transpiler tests #25

Closed
vicb opened this issue Sep 29, 2014 · 2 comments
Closed

transpiler: Improve transpiler tests #25

vicb opened this issue Sep 29, 2014 · 2 comments
Assignees

Comments

@vicb
Copy link
Contributor

vicb commented Sep 29, 2014

As today we test the transpiler by running the spec in JS and Dart. While this is a good start, there is room for improvement.

Asserting that some code snippets fail (with a given error message) could also really help improving the test suite.

An example could be for the generation of const constructor: in Dart such constructor could not have a body (it can only have an initializer list). Asserting that this case fails with a comprehensible error message would be really helpful.

@tbosch tbosch changed the title Improve transpiler tests transpiler: Improve transpiler tests Sep 29, 2014
@tbosch
Copy link
Contributor

tbosch commented Oct 1, 2014

For specs that should run only in Dart: use the .dart suffix and write them
in Dart
For specs that should only run in JS: use .es6 suffix

On Monday, September 29, 2014, Victor Berchet notifications@github.com
wrote:

As today we test the transpiler by running the spec in JS and Dart. While
this is a good start, there is room for improvement.

Asserting that some code snippets fail (with a given error message) could
also really help improving the test suite.

An example could be for the generation of const constructor: in Dart such
constructor could not have a body (it can only have an initializer list).
Asserting that this case fails with a comprehensible error message would be
really helpful.


Reply to this email directly or view it on GitHub
#25.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
dalejodc pushed a commit to dalejodc/angular that referenced this issue Sep 24, 2020
Co-authored-by: Alejandro Lora <alejandrofpo@gmail.com>
Co-authored-by: Pato <11162114+devpato@users.noreply.github.com>
Co-authored-by: José de Jesús Amaya <impepedev@gmail.com>

Closes angular#25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants