-
Notifications
You must be signed in to change notification settings - Fork 25.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(comiler): correct realPath to realpath #25023
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprobst
added
area: core
Issues related to the framework runtime
and removed
cla: yes
labels
Jul 22, 2018
mprobst
added
target: major
This PR is targeted for the next major release
and removed
cla: yes
labels
Jul 22, 2018
You can preview 07a92f6 at https://pr25023-07a92f6.ngbuilds.io/. |
alexeagle
approved these changes
Aug 1, 2018
The optional property on `ts.CompilerHost` is called `realpath` (lower case), not `realPath` (lower camel case). It is not clear to me what the impact of this is, but the author's intent was clearly to override `realpath`.
You can preview 8eacba0 at https://pr25023-8eacba0.ngbuilds.io/. |
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
The optional property on `ts.CompilerHost` is called `realpath` (lower case), not `realPath` (lower camel case). It is not clear to me what the impact of this is, but the author's intent was clearly to override `realpath`. PR Close angular#25023
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: core
Issues related to the framework runtime
cla: yes
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optional property on
ts.CompilerHost
is calledrealpath
(lower case), notrealPath
(lower camel case).It is not clear to me what the impact of this is, but the author's intent was clearly to override
realpath
.This was not caught by the compiler as
realpath
is optional, so these were just different properties.