Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comiler): correct realPath to realpath #25023

Closed
wants to merge 1 commit into from
Closed

fix(comiler): correct realPath to realpath #25023

wants to merge 1 commit into from

Conversation

mprobst
Copy link
Contributor

@mprobst mprobst commented Jul 22, 2018

The optional property on ts.CompilerHost is called realpath (lower case), not realPath (lower camel case).

It is not clear to me what the impact of this is, but the author's intent was clearly to override realpath.

This was not caught by the compiler as realpath is optional, so these were just different properties.

@mprobst mprobst requested a review from alexeagle July 22, 2018 07:31
@mprobst mprobst added area: core Issues related to the framework runtime and removed cla: yes labels Jul 22, 2018
@mprobst mprobst added target: major This PR is targeted for the next major release and removed cla: yes labels Jul 22, 2018
@mary-poppins
Copy link

You can preview 07a92f6 at https://pr25023-07a92f6.ngbuilds.io/.

@mprobst mprobst added the action: merge The PR is ready for merge by the caretaker label Aug 1, 2018
@ngbot
Copy link

ngbot bot commented Aug 1, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: test" is failing
    pending status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

The optional property on `ts.CompilerHost` is called `realpath` (lower
case), not `realPath` (lower camel case).

It is not clear to me what the impact of this is, but the author's
intent was clearly to override `realpath`.
@mary-poppins
Copy link

You can preview 8eacba0 at https://pr25023-8eacba0.ngbuilds.io/.

@IgorMinar IgorMinar closed this in 01e6dab Aug 1, 2018
@IgorMinar IgorMinar deleted the realpath branch October 16, 2018 21:36
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
The optional property on `ts.CompilerHost` is called `realpath` (lower
case), not `realPath` (lower camel case).

It is not clear to me what the impact of this is, but the author's
intent was clearly to override `realpath`.

PR Close angular#25023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants