Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): reordering how root is acquired #25470

Closed
wants to merge 2 commits into from

Conversation

benlesh
Copy link
Contributor

@benlesh benlesh commented Aug 14, 2018

Fixing issues that #25469 is trying to fix (but isn't passing in g3).

@benlesh benlesh added the target: major This PR is targeted for the next major release label Aug 14, 2018
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a comment about the significance of the order of these checks

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Aug 14, 2018
@mary-poppins
Copy link

You can preview c54045d at https://pr25470-c54045d.ngbuilds.io/.

benlesh added a commit to benlesh/angular that referenced this pull request Aug 14, 2018
@benlesh benlesh mentioned this pull request Aug 14, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants