Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): more rebust global detection. #25469

Closed
wants to merge 1 commit into from

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Aug 13, 2018

No description provided.

@benlesh benlesh added the target: major This PR is targeted for the next major release label Aug 13, 2018
@benlesh
Copy link
Contributor

benlesh commented Aug 13, 2018

NOTE: Verified to resolve google3 sync issue in google3 citc environment.

@mary-poppins
Copy link

You can preview ae175e6 at https://pr25469-ae175e6.ngbuilds.io/.

@mhevery
Copy link
Contributor Author

mhevery commented Aug 13, 2018

@benlesh
Copy link
Contributor

benlesh commented Aug 14, 2018

Closing for #25470 because of TAP failures (g3 doesn't like global this)

@benlesh benlesh closed this Aug 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants