Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: check for latest Chromium version #25602

Closed
wants to merge 2 commits into from
Closed

build: check for latest Chromium version #25602

wants to merge 2 commits into from

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Aug 21, 2018

Now that https://omahaproxy.appspot.com/all is back up, we can restore the check for newer available version of Chromium.

Fixes #22231

@gkalpak gkalpak added area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release and removed cla: yes labels Aug 21, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@gkalpak gkalpak force-pushed the build-check-latest-chromium branch from 1145dfc to 9a50088 Compare August 22, 2018 16:18
@IgorMinar IgorMinar self-requested a review August 22, 2018 20:25
@gkalpak gkalpak force-pushed the build-check-latest-chromium branch from 9a50088 to 377b7e6 Compare August 23, 2018 13:58
@gkalpak
build: check for latest Chromium version
9efe96c 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes angular#22231
@gkalpak gkalpak force-pushed the build-check-latest-chromium branch from 377b7e6 to c0be49d Compare August 23, 2018 14:02
@mary-poppins
Copy link

You can preview 377b7e6 at https://pr25602-377b7e6.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c0be49d at https://pr25602-c0be49d.ngbuilds.io/.

@gkalpak gkalpak force-pushed the build-check-latest-chromium branch from c0be49d to 36543cf Compare August 23, 2018 14:47
@gkalpak gkalpak force-pushed the build-check-latest-chromium branch from 36543cf to 7e34f27 Compare August 23, 2018 14:49
@mary-poppins
Copy link

You can preview 36543cf at https://pr25602-36543cf.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 7e34f27 at https://pr25602-7e34f27.ngbuilds.io/.

IgorMinar
IgorMinar approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if the CI is happy.

@IgorMinar IgorMinar removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 23, 2018
@IgorMinar
Copy link
Contributor

if CI passes please add the merge label and merge-assistance with a note that this doesn't have impact on g3.

@gkalpak
Copy link
Member Author

gkalpak commented Aug 23, 2018

CI was green. I'll restart the aio_e2e jobs a few times to make sure they are not flakey and mark for merge.

(Background: The aio_e2e jobs were super flakey with some older Chromium/ChromeDriver versions and we had to pin them to even older versions. I want to make sure whatever was causing the flakes has been fixed in the latest versions.)

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 23, 2018
@gkalpak
Copy link
Member Author

gkalpak commented Aug 23, 2018

Note to caretaker: No g3 impact.

@matsko
Copy link
Contributor

matsko commented Aug 23, 2018

@gkalpak running g3 presubmit...

@matsko
Copy link
Contributor

matsko commented Aug 23, 2018 •
edited

http://test/ui#id=OCL:209985435:BASE:209985520:1535054859216:d9c900d6

@matsko matsko removed the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 23, 2018
@matsko
Copy link
Contributor

matsko commented Aug 23, 2018

@gkalpak this doesn't patch cleanly into 6.x. Please fix.

@matsko matsko removed the action: merge The PR is ready for merge by the caretaker label Aug 23, 2018
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 23, 2018
@gkalpak
Copy link
Member Author

gkalpak commented Aug 23, 2018

@matsko, let's merge this into master only. I will create a separate PR for patch.

@matsko matsko closed this in efb453c Aug 24, 2018
matsko pushed a commit that referenced this pull request Aug 24, 2018
@gkalpak @matsko
build: upgrade Chromium and ChromeDriver to latest versions (#25602)
18f129f 
PR Close #25602
@gkalpak gkalpak deleted the build-check-latest-chromium branch August 24, 2018 19:16
gkalpak added a commit to gkalpak/angular that referenced this pull request Aug 25, 2018
@gkalpak
build: check for latest Chromium version (angular#25602)
44ac5ae 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes angular#22231

PR Close angular#25602
gkalpak added a commit to gkalpak/angular that referenced this pull request Aug 25, 2018
@gkalpak
build: upgrade Chromium and ChromeDriver to latest versions (angular#…
0857e98 
…25602)

PR Close angular#25602
This was referenced Aug 25, 2018
Closed
Closed
@gkalpak
Copy link
Member Author

gkalpak commented Aug 25, 2018

See #25669.

mhevery pushed a commit that referenced this pull request Sep 5, 2018
@gkalpak @mhevery
build: check for latest Chromium version (#25602) (#25669)
3bdd4e2 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes #22231

PR Close #25602

PR Close #25669
mhevery pushed a commit that referenced this pull request Sep 5, 2018
@gkalpak @mhevery
build: upgrade Chromium and ChromeDriver to latest versions (#25602) (#…
3a0b735 
…25669)

PR Close #25602

PR Close #25669
gkalpak added a commit to gkalpak/angular that referenced this pull request Sep 5, 2018
@gkalpak
build: remove obsolete comment in env.sh
85d59c7 
The comment is no longer true since angular#25602.
@gkalpak gkalpak mentioned this pull request Sep 5, 2018
Closed
gkalpak added a commit to gkalpak/angular that referenced this pull request Sep 25, 2018
@gkalpak
build: remove obsolete comment in env.sh
f218e0f 
The comment is no longer true since angular#25602.
kara pushed a commit that referenced this pull request Sep 25, 2018
@gkalpak @kara
build: remove obsolete comment in env.sh (#25819)
482e12c 
The comment is no longer true since #25602.

PR Close #25819
kara pushed a commit that referenced this pull request Sep 25, 2018
@gkalpak @kara
build: remove obsolete comment in env.sh (#25819)
42e2e7c 
The comment is no longer true since #25602.

PR Close #25819
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@gkalpak @FrederikSchlemmer
build: check for latest Chromium version (angular#25602)
e543c2f 
Now that https://omahaproxy.appspot.com/all is back up, we can restore
the check for newer available version of Chromium.

Fixes angular#22231

PR Close angular#25602
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@gkalpak @FrederikSchlemmer
build: upgrade Chromium and ChromeDriver to latest versions (angular#…
73c5839 
…25602)

PR Close angular#25602
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@gkalpak @FrederikSchlemmer
build: remove obsolete comment in env.sh (angular#25819)
5d59c7f 
The comment is no longer true since angular#25602.

PR Close angular#25819
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore install-chromium.sh version checking once https://omahaproxy.appspot.com/all is back
5 participants
@gkalpak @googlebot @mary-poppins @IgorMinar @matsko