Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(bazel): esm5_outputs_aspect to work with targets such as ts_proto_library with no replay_params attribute #25605

Closed
wants to merge 1 commit into from
Closed

build(bazel): esm5_outputs_aspect to work with targets such as ts_proto_library with no replay_params attribute #25605

wants to merge 1 commit into from

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan added target: patch This PR is targeted for the next patch release and removed cla: yes labels Aug 21, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@mary-poppins
Copy link

You can preview 28c1097 at https://pr25605-28c1097.ngbuilds.io/.

@gregmagolan gregmagolan mentioned this pull request Aug 21, 2018
Closed
@mary-poppins
Copy link

You can preview af59718 at https://pr25605-af59718.ngbuilds.io/.

@gregmagolan gregmagolan force-pushed the ts-issue-211-workaround branch 2 times, most recently from fecc258 to db228d2 Compare August 21, 2018 23:21
@mary-poppins
Copy link

You can preview fecc258 at https://pr25605-fecc258.ngbuilds.io/.

@mary-poppins
Copy link

You can preview db228d2 at https://pr25605-db228d2.ngbuilds.io/.

@gregmagolan gregmagolan added the action: merge The PR is ready for merge by the caretaker label Aug 22, 2018
@matsko
Copy link
Contributor

matsko commented Aug 23, 2018

@gregmagolan this fails to work in the patch branch (which is 6.x). Please fix.

@matsko matsko added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Aug 23, 2018
@gregmagolan gregmagolan added target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker and removed target: patch This PR is targeted for the next patch release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Aug 23, 2018
@gregmagolan
Copy link
Contributor Author

@matsko Conflict is just whitespace changes. Will create separate PR for patch.

@gregmagolan gregmagolan mentioned this pull request Aug 23, 2018
Closed
@mary-poppins
Copy link

You can preview 0ee47f6 at https://pr25605-0ee47f6.ngbuilds.io/.

@gregmagolan gregmagolan removed the action: merge The PR is ready for merge by the caretaker label Aug 23, 2018
@mary-poppins
Copy link

You can preview 0457745 at https://pr25605-0457745.ngbuilds.io/.

@gregmagolan
Copy link
Contributor Author

circle_ci integration test failing. will get fixed by #25650

@gregmagolan gregmagolan added the area: bazel Issues related to the published `@angular/bazel` build rules label Aug 27, 2018
@mary-poppins
Copy link

You can preview f840bfb at https://pr25605-f840bfb.ngbuilds.io/.

@gregmagolan gregmagolan added the action: merge The PR is ready for merge by the caretaker label Aug 27, 2018
@matsko matsko closed this in 366195e Aug 27, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@gregmagolan @FrederikSchlemmer
build(bazel): esm5_outputs_aspect to work with targets such as ts_pro…
a548044 
…to_library with no replay_params attribute (angular#25605)

PR Close angular#25605
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gregmagolan @googlebot @mary-poppins @matsko @alexeagle