Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(bazel): esm5_outputs_aspect to work with targets such as ts_proto_library with no replay_params attribute (6.1.x) #25648

Closed

Conversation

gregmagolan
Copy link
Contributor

6.1.x version of #25605

@mary-poppins
Copy link

You can preview 334f2a8 at https://pr25648-334f2a8.ngbuilds.io/.

@gregmagolan gregmagolan changed the title build(bazel): esm5_outputs_aspect to work with targets such as ts_proto_library with no replay_params attribute build(bazel): esm5_outputs_aspect to work with targets such as ts_proto_library with no replay_params attribute (6.1.x) Aug 23, 2018
@gregmagolan gregmagolan added the action: merge The PR is ready for merge by the caretaker label Aug 23, 2018
matsko pushed a commit that referenced this pull request Aug 24, 2018
…to_library with no replay_params attribute (#25648)

PR Close #25648
@matsko
Copy link
Contributor

matsko commented Aug 27, 2018

@gregmagolan @alexeagle this doesn't cherry-pick onto patch properly. Please fix.

@matsko
Copy link
Contributor

matsko commented Aug 27, 2018

The cherry-pick result is empty when patched onto 6.1.x

@alexeagle
Copy link
Contributor

alexeagle commented Aug 27, 2018 via email

@gregmagolan
Copy link
Contributor Author

gregmagolan commented Aug 27, 2018

@matsko Was it already merged earlier? There is another PR for master #25605

@matsko matsko added target: major This PR is targeted for the next major release PR target: patch-only and removed PR target: patch-only target: major This PR is targeted for the next major release labels Aug 27, 2018
@matsko
Copy link
Contributor

matsko commented Aug 27, 2018

@matsko matsko closed this Aug 27, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants