New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bazel): specify the package and lock files using the workspace #25694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
changed the title
fix(bazel): specify the package and lock files using the workspace
fix(bazel): specify the package and lock files using the workspace (WIP)
Aug 28, 2018
alan-agius4
changed the title
fix(bazel): specify the package and lock files using the workspace (WIP)
fix(bazel): specify the package and lock files using the workspace
Aug 28, 2018
alexeagle
approved these changes
Sep 7, 2018
Thanks @alexeagle!
…On Fri, 07 Sep 2018 at 16:38, Alex Eagle ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tools/ts-api-guardian/index.bzl
<#25694 (comment)>:
> @@ -17,14 +17,12 @@
***@***.***_bazel_rules_nodejs//internal/node:node.bzl", "nodejs_binary", "nodejs_test")
-COMMON_MODULE_IDENTIFIERS = ["angular", "jasmine", "protractor"]
I went ahead and made the change so we can get this greened up
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#25694 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQv-Wq_EFhrs2sX7CZtIGZ-ldxzbL5nFks5uYoT9gaJpZM4WO8Km>
.
|
Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream
This PR doesn't apply cleanly to the patch branch. @alan-agius4 can you send a separate PR for that branch please? |
Yeah I can do that tomorrow. Most likely it will have to contain the
changes of the following PR as well
#25690 as it was merged only to
master.
…On Fri, 07 Sep 2018 at 22:51, Igor Minar ***@***.***> wrote:
This PR doesn't apply cleanly to the patch branch. @alan-agius4
<https://github.com/alan-agius4> can you send a separate PR for that
branch please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25694 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQv-WhQnsu23ptaRimRdxHrDxyGQPwjjks5uYtxjgaJpZM4WO8Km>
.
|
IgorMinar
added
target: major
This PR is targeted for the next major release
and removed
target: patch
This PR is targeted for the next patch release
labels
Sep 7, 2018
alexeagle
pushed a commit
to alexeagle/angular
that referenced
this pull request
Sep 18, 2018
alexeagle
pushed a commit
to alexeagle/angular
that referenced
this pull request
Sep 18, 2018
…ngular#25694) Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream PR Close angular#25694
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
FrederikSchlemmer
pushed a commit
to FrederikSchlemmer/angular
that referenced
this pull request
Jan 3, 2019
…ngular#25694) Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream PR Close angular#25694
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
cla: yes
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
When used downstream (CLI), The following error is being thrown
//cc @alexeagle