Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): specify the package and lock files using the workspace #25694

Closed
wants to merge 2 commits into from
Closed

fix(bazel): specify the package and lock files using the workspace #25694

wants to merge 2 commits into from

Conversation

alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Aug 28, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
When used downstream (CLI), The following error is being thrown

no such package '@ts-api-guardian_runtime_deps//': Unable to load package for //tools/ts-api-guardian:package.json: not found. and referenced by '//etc/api:angular_devkit_schematics_tasks_api'

no such package 'tools/ts-api-guardian': BUILD file not found on package path and referenced by '//etc/api:angular_devkit_schematics_testing_api.accept'
[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

//cc @alexeagle

@alan-agius4 alan-agius4 changed the title fix(bazel): specify the package and lock files using the workspace fix(bazel): specify the package and lock files using the workspace (WIP) Aug 28, 2018
@alan-agius4 alan-agius4 changed the title fix(bazel): specify the package and lock files using the workspace (WIP) fix(bazel): specify the package and lock files using the workspace Aug 28, 2018
@alexeagle alexeagle added the target: patch This PR is targeted for the next patch release label Sep 7, 2018
tools/ts-api-guardian/index.bzl Outdated Show resolved Hide resolved
@alexeagle alexeagle added the action: merge The PR is ready for merge by the caretaker label Sep 7, 2018
@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Sep 7, 2018 via email

Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream
@IgorMinar
Copy link
Contributor

This PR doesn't apply cleanly to the patch branch. @alan-agius4 can you send a separate PR for that branch please?

@alan-agius4
Copy link
Contributor Author

alan-agius4 commented Sep 7, 2018 via email

@IgorMinar IgorMinar added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Sep 7, 2018
@IgorMinar IgorMinar closed this in ddc1335 Sep 7, 2018
IgorMinar pushed a commit that referenced this pull request Sep 7, 2018
…25694)

Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream

PR Close #25694
alexeagle pushed a commit to alexeagle/angular that referenced this pull request Sep 18, 2018
alexeagle pushed a commit to alexeagle/angular that referenced this pull request Sep 18, 2018
…ngular#25694)

Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream

PR Close angular#25694
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
…ngular#25694)

Added `strip_export_pattern` and `allow_module_identifiers` so that these can be passed from downstream

PR Close angular#25694
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants