Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ivy): enhance [style] and [class] bindings to be animation aware #26096

Closed
wants to merge 4 commits into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Sep 25, 2018

No description provided.

@mary-poppins
Copy link

You can preview 98fdf28 at https://pr26096-98fdf28.ngbuilds.io/.

@mary-poppins
Copy link

You can preview c45f1d0 at https://pr26096-c45f1d0.ngbuilds.io/.

@matsko matsko requested a review from mhevery September 26, 2018 17:14
@matsko matsko added the target: major This PR is targeted for the next major release label Sep 26, 2018
@mary-poppins
Copy link

You can preview 647b2f0 at https://pr26096-647b2f0.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2eb616c at https://pr26096-2eb616c.ngbuilds.io/.

@mary-poppins
Copy link

You can preview b8327b5 at https://pr26096-b8327b5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview e10af45 at https://pr26096-e10af45.ngbuilds.io/.

@matsko matsko force-pushed the players branch 2 times, most recently from 213646d to 02a5e45 Compare September 27, 2018 05:03
@mary-poppins
Copy link

You can preview 213646d at https://pr26096-213646d.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 02a5e45 at https://pr26096-02a5e45.ngbuilds.io/.

@mary-poppins
Copy link

You can preview b8d098f at https://pr26096-b8d098f.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 19d06ab at https://pr26096-19d06ab.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 8d3f767 at https://pr26096-8d3f767.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 6cc7d39 at https://pr26096-6cc7d39.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 4e668f5 at https://pr26096-4e668f5.ngbuilds.io/.

@mary-poppins
Copy link

You can preview 2f9452a at https://pr26096-2f9452a.ngbuilds.io/.

@matsko matsko added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 16, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@mary-poppins
Copy link

You can preview 5cf81d0 at https://pr26096-5cf81d0.ngbuilds.io/.

@matsko matsko added target: major This PR is targeted for the next major release cla: yes and removed target: patch This PR is targeted for the next patch release cla: no labels Oct 16, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@mary-poppins
Copy link

You can preview 591d0fa at https://pr26096-591d0fa.ngbuilds.io/.

@matsko matsko added the action: merge The PR is ready for merge by the caretaker label Oct 16, 2018
@mhevery mhevery closed this in be337a2 Oct 17, 2018
mhevery pushed a commit that referenced this pull request Oct 18, 2018
sculove pushed a commit to sculove/angular that referenced this pull request Nov 2, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@matsko matsko deleted the players branch January 17, 2019 19:44
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants