fixup! feat(ivy): enhance [style] and [class] bindings to be animatio…

…n aware
angular · Sep 26, 2018 · b8327b5 · b8327b5
1 parent 2eb616c
commit b8327b5
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 13 deletions.
diff --git a/packages/core/src/render3/component.ts b/packages/core/src/render3/component.ts
@@ -17,7 +17,6 @@ import {getLElementFromComponent, readPatchedLViewData} from './context_discover
 import {getComponentDef} from './definition';
 import {queueInitHooks, queueLifecycleHooks} from './hooks';
 import {PlayerHandler} from './styling/interfaces';
-
 import {CLEAN_PROMISE, baseDirectiveCreate, createLViewData, createTView, detectChangesInternal, enterView, executeInitAndContentHooks, hostElement, leaveView, locateHostElement, setHostBindings, queueHostBindingForCheck,} from './instructions';
 import {ComponentDef, ComponentDefInternal, ComponentType} from './interfaces/definition';
 import {LElementNode} from './interfaces/node';
@@ -26,7 +25,6 @@ import {CONTEXT, INJECTOR, LViewData, LViewFlags, RootContext, RootContextFlags,
 import {getRootView, stringify} from './util';
 
 
-
 /** Options that control how the component should be bootstrapped. */
 export interface CreateComponentOptions {
   /** Which renderer factory to use. */

diff --git a/packages/core/src/render3/instructions.ts b/packages/core/src/render3/instructions.ts
@@ -11,7 +11,6 @@ import './ng_dev_mode';
 import {QueryList} from '../linker';
 import {Sanitizer} from '../sanitization/security';
 import {StyleSanitizeFn} from '../sanitization/style_sanitizer';
-
 import {assertDefined, assertEqual, assertLessThan, assertNotEqual} from './assert';
 import {attachPatchData, getLElementFromComponent, readElementValue, readPatchedLViewData} from './context_discovery';
 import {getRootView} from './discovery_utils';

diff --git a/packages/core/src/render3/styling/class_and_style_bindings.ts b/packages/core/src/render3/styling/class_and_style_bindings.ts
@@ -6,23 +6,18 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-// 1. How to clear the players array in a stable way (indices are fine)
-// 2. How to delegate to a previous player when a single prop guy doesn't have one
-
 import {StyleSanitizeFn} from '../../sanitization/style_sanitizer';
 import {getRootContext} from '../discovery_utils';
 import {InitialStylingFlags} from '../interfaces/definition';
 import {LElementNode} from '../interfaces/node';
 import {Renderer3, RendererStyleFlags3, isProceduralRenderer} from '../interfaces/renderer';
 import {LViewData} from '../interfaces/view';
-
 import {BindingPlayerFactory} from './binding_player_factory';
 import {BindingStore, BindingType, InitialStyles, Player, PlayerFactory, PlayerIndex, StylingContext, StylingFlags, StylingIndex} from './interfaces';
 import {allocPlayerContext, queuePlayer} from './players';
 import {getPlayerContext} from './util';
 
 
-
 /**
  * Used clone a copy of a pre-computed template of a styling context.
  *
@@ -503,15 +498,10 @@ export function renderStyleAndClassBindings(
               playerFactory);
         }
         setDirty(context, i, false);
-
         flushPlayerFactories = flushPlayerFactories || playerFactory && playerFactory.dirty;
       }
     }
 
-    // TODO (matsko): skip a map-based player if the same property is animated in a single prop
-    // player
-    // TODO (matsko): cancel an existing player (in the map space) if the same property is changed
-    // afterwards
     if (flushPlayerFactories) {
       const rootContext = getRootContext(currentView);
       const playerContext = getPlayerContext(context) !;