Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-watch doesn't work in gulp test.unit.dart #2662

Closed
pkozlowski-opensource opened this issue Jun 21, 2015 · 7 comments
Closed

Auto-watch doesn't work in gulp test.unit.dart #2662

pkozlowski-opensource opened this issue Jun 21, 2015 · 7 comments
Labels
area: build & ci Related the build and CI infrastructure of the project
Milestone
alpha-30

Comments

@pkozlowski-opensource
Copy link
Member

After fresh install from master / npm:

  • run gulp test.unit.dart
  • touch any file that triggers tests re-run.

There is an error on the console and subsequent run is not triggered:

[14:28:09] Starting '!build/tree.dart'...
[14:28:11] '!build/tree.dart' errored after 1.92 s
[14:28:11] TypeError: [MergeTrees]: Cannot read property 'forEach' of undefined
at /Users/pawelkozlowski/work/gitrepos/pkozlowski-opensource/angular/broccoli-merge-trees.ts:76:30
at Array.forEach (native)
at MergeTrees.rebuild (/Users/pawelkozlowski/work/gitrepos/pkozlowski-opensource/angular/broccoli-merge-trees.ts:74:27)
at DiffingPluginWrapper.rebuild (/Users/pawelkozlowski/work/gitrepos/pkozlowski-opensource/angular/diffing-broccoli-plugin.ts:106:39)
at /Users/pawelkozlowski/work/gitrepos/pkozlowski-opensource/angular/node_modules/broccoli/lib/api_compat.js:42:21
at lib$rsvp$$internal$$tryCatch (/Users/pawelkozlowski/work/gitrepos/pkozlowski-opensource/angular/node_modules/broccoli/node_modules/rsvp/dist/rsvp.js:489:16)
at lib$rsvp$$internal$$invokeCallback (/Users/pawelkozlowski/work/gitrepos/pkozlowski-opensource/angular/node_modules/broccoli/node_modules/rsvp/dist/rsvp.js:501:17)
at /Users/pawelkozlowski/work/gitrepos/pkozlowski-opensource/angular/node_modules/broccoli/node_modules/rsvp/dist/rsvp.js:1095:13
at lib$rsvp$asap$$flush (/Users/pawelkozlowski/work/gitrepos/pkozlowski-opensource/angular/node_modules/broccoli/node_modules/rsvp/dist/rsvp.js:1290:9)
at process._tickCallback (node.js:355:11)

This makes working on Dart-related code quite challenging, atm...
@pkozlowski-opensource pkozlowski-opensource added comp: build/pipeline area: build & ci Related the build and CI infrastructure of the project labels Jun 21, 2015
@pkozlowski-opensource
Copy link
Member Author

@caitp it might be related to d575915 - are there any special cleanup steps that I should take after pulling this sha1?

@vicb
Copy link
Contributor

vicb commented Jun 22, 2015

same error here (Ubuntu)

@vicb vicb mentioned this issue Jun 22, 2015
Closed
@tbosch
Copy link
Contributor

tbosch commented Jun 22, 2015

Just tried: reverting d575915 makes the incremental build work again...

@naomiblack naomiblack added this to the alpha-30 milestone Jun 23, 2015
@naomiblack
Copy link
Contributor

@tbosch @IgorMinar @mhevery can we find someone to own this in alpha-29? It would be great to resolve quickly if possible. Any suggestions since @caitp is out?

@caitp
Copy link
Contributor

caitp commented Jun 23, 2015

I can take some time to fix this today. For the time being, reverting d575915 should get it working again

caitp added a commit to caitp/angular that referenced this issue Jun 23, 2015
@caitp
build(broccoli): store DiffResult for re-use only if DiffResult
7a80c6e 
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.

Closes angular#2662
@caitp caitp mentioned this issue Jun 23, 2015
Closed
caitp added a commit to caitp/angular that referenced this issue Jun 23, 2015
@caitp
build(broccoli): store DiffResult for re-use only if DiffResult
03f8334 
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.

Closes angular#2662
tbosch added a commit that referenced this issue Jun 23, 2015
@tbosch
Revert "build(broccoli): allow rebuild() to return DiffResult"
2c3c235 
This reverts commit d575915.

See #2662
@tbosch
Copy link
Contributor

tbosch commented Jun 23, 2015

@pkozlowski-opensource @caitp I reverted the commit for now on master.

caitp added a commit to caitp/angular that referenced this issue Jun 26, 2015
@caitp
build(broccoli): store DiffResult for re-use only if DiffResult
4dbee01 
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.

Closes angular#2662
caitp added a commit to caitp/angular that referenced this issue Jun 26, 2015
@caitp
build(broccoli): store DiffResult for re-use only if DiffResult
0949fbe 
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.

Closes angular#2662
caitp added a commit to caitp/angular that referenced this issue Jun 26, 2015
@caitp
build(broccoli): store DiffResult for re-use only if DiffResult
c18eb92 
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.

Closes angular#2662
caitp added a commit to caitp/angular that referenced this issue Jun 29, 2015
@caitp
build(broccoli): store DiffResult for re-use only if DiffResult
d0d4742 
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.

Closes angular#2662
@caitp caitp closed this as completed in a93ec73 Jun 29, 2015
jimthedev pushed a commit to jimthedev/angular that referenced this issue Jun 30, 2015
@tbosch @jimthedev
Revert "build(broccoli): allow rebuild() to return DiffResult"
7480447 
This reverts commit d575915.

See angular#2662
jimthedev pushed a commit to jimthedev/angular that referenced this issue Jun 30, 2015
@caitp @jimthedev
build(broccoli): store DiffResult for re-use only if DiffResult
075a15b 
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.

Closes angular#2662
jimthedev pushed a commit to jimthedev/angular that referenced this issue Jun 30, 2015
@tbosch @jimthedev
Revert "build(broccoli): allow rebuild() to return DiffResult"
3db18fa 
This reverts commit d575915.

See angular#2662
jimthedev pushed a commit to jimthedev/angular that referenced this issue Jun 30, 2015
@caitp @jimthedev
build(broccoli): store DiffResult for re-use only if DiffResult
250eff3 
One of the non-angular broccoli plugins returns a weird object. We can't
assume that all trees meet the contract that we expect them to meet, so
we do a typecheck before storing the result of the rebuild.

Closes angular#2662
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: build & ci Related the build and CI infrastructure of the project
Projects
None yet
Milestone
alpha-30
Development

Successfully merging a pull request may close this issue.

build(broccoli): store DiffResult for re-use only if DiffResult caitp/angular
5 participants
@vicb @tbosch @pkozlowski-opensource @naomiblack @caitp