Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in comment in AnimationRendererFactory #27294

Closed
wants to merge 1 commit into from
Closed

docs: fix typo in comment in AnimationRendererFactory #27294

wants to merge 1 commit into from

Conversation

kaito0228
Copy link
Contributor

@kaito0228 kaito0228 commented Nov 27, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No changes.
Issue Number: N/A

What is the new behavior?

No changes.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@kaito0228
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@jenniferfell jenniferfell added type: bug/fix comp: docs area: animations effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR labels Nov 28, 2018
@ngbot ngbot bot added this to the Backlog milestone Nov 28, 2018
@jenniferfell jenniferfell self-assigned this Nov 28, 2018
@jenniferfell jenniferfell changed the title docs: fix typo docs: fix typo in comment in AnimationRendererFactory Nov 28, 2018
@jenniferfell
Copy link
Contributor

@kaito0228 : Hi. Thanks for submitting this fix. We've had some intermittent issues with CircleCI. Would you rebase against master and push again please? That might resolve the CircleCI issues. Thanks!

@jenniferfell
Copy link
Contributor

@IgorMinar : Hi. This PR has an edit to a command in an animations API that is private. There's no published doc on AIO, but it's a low risk spelling change. Requires pull approval from you. Thanks!

@kaito0228
Copy link
Contributor Author

@jenniferfell
Hi, I make other PR(#27327).
But, CircleCI has an issue again.
If one will be merged, you will be able to close the other.
Thanks.

@IgorMinar IgorMinar added the action: merge The PR is ready for merge by the caretaker label Nov 30, 2018
@ngbot
Copy link

ngbot bot commented Nov 30, 2018

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: aio_preview" is failing
    failure status "ci/circleci: test_aio" is failing
    failure status "ci/circleci: test_aio_tools" is failing
    failure status "ci/circleci: test_docs_examples_1" is failing
    failure status "ci/circleci: test_docs_examples_0" is failing
    failure status "ci/circleci: test_aio_local" is failing
    pending missing required labels: PR target: *
    pending status "code-review/pullapprove" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@IgorMinar IgorMinar added the target: patch This PR is targeted for the next patch release label Nov 30, 2018
@IgorMinar IgorMinar closed this in 9129f9a Nov 30, 2018
IgorMinar pushed a commit that referenced this pull request Nov 30, 2018
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
@kaito0228 kaito0228 deleted the FixTypo branch September 16, 2019 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: animations cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants