Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(animations): fix typo in animation renderer comments #27327

Closed
wants to merge 1 commit into from
Closed

docs(animations): fix typo in animation renderer comments #27327

wants to merge 1 commit into from

Conversation

kaito0228
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

No change.
Issue Number: N/A

What is the new behavior?

No change.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

I pushed this fix yesterday. Then, CircleCi had some issue.
I retry push this branch that rebase FixTypo branch.
If this PR is merged, Please close the following PR.
#27294

@brandonroberts brandonroberts self-assigned this Nov 29, 2018
@brandonroberts brandonroberts added type: bug/fix comp: docs area: animations effort1: hours target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR labels Nov 29, 2018
@ngbot ngbot bot added this to the Backlog milestone Nov 29, 2018
@brandonroberts brandonroberts added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 4, 2018
@brandonroberts brandonroberts changed the title docs: fix typo docs(animations): fix typo in animation renderer comments Dec 11, 2018
@matsko matsko added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 13, 2018
@mhevery
Copy link
Contributor

mhevery commented Dec 14, 2018

already resolved in 9129f9a

@mhevery mhevery closed this Dec 14, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: animations cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants