Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Percent pipe documentation #27365

Closed
wants to merge 2 commits into from
Closed

Percent pipe documentation #27365

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 30, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: Additional tests

What is the current behavior?

The documentation states the maxFractionDigits parameter in the PercentPipe defaults to 3. In testing Angular versions 5.x.x through 7.x.x, the default maxFractionDigits seems to be 0.

Issue Number: #27079

What is the new behavior?

The documentation states the maxFractionDigits parameter in the PercentPipe defaults to 0. Two tests now cover the scenarios of trimming extra fraction digits and their appropriate rounding.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Although this is my first PR, I've enjoyed Angular since beta and am excited to start contributing! If something is missing or incorrect, please let me know and I'll be happy to make the necessary changes. Feedback is also greatly appreciated!

Best regards,

Chris

Christopher Dahm added 2 commits November 29, 2018 22:45
docs(common): update PercentPipe default maxFractionDigits value
e9de37f 
Change the docs to reflect the actual default value

Fixes #27079
test(common): add PercentPipe round and trim tests
216a7ef 
Add tests to cover the percent's decimal to be rounded and trimmed.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@ghost
Copy link
Author

ghost commented Nov 30, 2018

Updated CLA for alternate email address

@googlebot
Copy link

CLAs look good, thanks!

@brandonroberts brandonroberts self-assigned this Nov 30, 2018
@brandonroberts brandonroberts added comp: docs action: review The PR is still awaiting reviews from at least one requested reviewer area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release state: community Someone from the Angular community is working on this issue or submitted this PR labels Nov 30, 2018
@ngbot ngbot bot added this to the needsTriage milestone Nov 30, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Nov 30, 2018
@ocombe
Copy link
Contributor

ocombe commented Dec 3, 2018

Thanks for catching this! PR looks good, it even has tests, kudos! 👍

@pkozlowski-opensource
Copy link
Member

LGTM

@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 3, 2018
@ghost ghost mentioned this pull request Dec 3, 2018
Closed
14 tasks
@IgorMinar IgorMinar closed this in f3f2ef4 Dec 3, 2018
IgorMinar pushed a commit that referenced this pull request Dec 3, 2018
@IgorMinar
test(common): add PercentPipe round and trim tests (#27365)
d847051 
Add tests to cover the percent's decimal to be rounded and trimmed.
PR Close #27365
IgorMinar pushed a commit that referenced this pull request Dec 3, 2018
@IgorMinar
docs(common): update PercentPipe default maxFractionDigits value (#27365
560cb99 
)

Change the docs to reflect the actual default value

Fixes #27079
PR Close #27365
IgorMinar pushed a commit that referenced this pull request Dec 3, 2018
@IgorMinar
test(common): add PercentPipe round and trim tests (#27365)
1022db1 
Add tests to cover the percent's decimal to be rounded and trimmed.
PR Close #27365
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@FrederikSchlemmer
docs(common): update PercentPipe default maxFractionDigits value (ang…
97b9d64 
…ular#27365)

Change the docs to reflect the actual default value

Fixes angular#27079
PR Close angular#27365
FrederikSchlemmer pushed a commit to FrederikSchlemmer/angular that referenced this pull request Jan 3, 2019
@FrederikSchlemmer
test(common): add PercentPipe round and trim tests (angular#27365)
f5abce7 
Add tests to cover the percent's decimal to be rounded and trimmed.
PR Close angular#27365
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@ngfelixl
docs(common): update PercentPipe default maxFractionDigits value (ang…
4a2caa4 
…ular#27365)

Change the docs to reflect the actual default value

Fixes angular#27079
PR Close angular#27365
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
@ngfelixl
test(common): add PercentPipe round and trim tests (angular#27365)
8c8c6c6 
Add tests to cover the percent's decimal to be rounded and trimmed.
PR Close angular#27365
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@brandonroberts brandonroberts

@pkozlowski-opensource pkozlowski-opensource

Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package cla: yes effort1: hours risk: low state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@googlebot @ocombe @pkozlowski-opensource @brandonroberts