docs(common): update currencyPipe default digitsInfo values #27417
Conversation
Change the docs to reflect the actual default values Fixes #27414
brandonroberts
added
type: bug/fix
comp: docs
action: review
|
Thanks for catching this as well! |
| @@ -179,9 +179,9 @@ export class CurrencyPipe implements PipeTransform { | |||
| * - `minIntegerDigits`: The minimum number of integer digits before the decimal point. | |||
| * Default is `1`. | |||
| * - `minFractionDigits`: The minimum number of digits after the decimal point. | |||
| * Default is `0`. | |||
| * Default is `2`. | |||
There was a problem hiding this comment.
This doesn't sound right, from my testing it is 0, as in the docs: https://stackblitz.com/edit/angular-hqmbt7?file=src%2Fapp%2Fapp.component.html
| * - `maxFractionDigits`: The maximum number of digits after the decimal point. | ||
| * Default is `3`. | ||
| * Default is `2`. |
There was a problem hiding this comment.
This doesn't sound right, from my testing it is 3, as in the docs: https://stackblitz.com/edit/angular-hqmbt7?file=src%2Fapp%2Fapp.component.html
There was a problem hiding this comment.
Oh wait, this is about the currency pipe, right? So indeed this change seems good: https://stackblitz.com/edit/angular-hqmbt7?file=src%2Fapp%2Fapp.component.html
pkozlowski-opensource
removed
the
action: review
pkozlowski-opensource
added
action: merge
|
Merge assistance as this needs g3 presubmit... |
…27417) Change the docs to reflect the actual default values Fixes angular#27414 PR Close angular#27417
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Change the docs to reflect the actual default values
Fixes #27414
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The docs say the digitsInfo has a minFractionDigits of 0 and a maxFractionDigits of 3.
Issue Number: #27414
Related to: #27079
What is the new behavior?
The docs say the digitsInfo has a minFractionDigits of 2 and a maxFractionDigits of 2.
Does this PR introduce a breaking change?
Other information
Tests already exist to prove the scenarios for the defaults.
I apologize for a second PR for the same kind of issue, but I did not notice this until after the other PR. Would you rather have this added to the first PR?