fix(compiler-cli): ngtsc shim files not being generated on case-insensitive platforms

[devversion]

Common insensitive platforms are win32/win64 (see: here)

Currently when running bazel build packages/core --define=compile=aot, the compiler-cli will throw because it cannot find the index.ngfactory.ts file in the compiler host. This is because the shim host wrapper is not properly generating the requested ngfactory file.

 Error: ENOENT: no such file or directory, open 'C:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ngfactory.ts'
    at Object.openSync (fs.js:434:3)
    at Object.readFileSync (fs.js:339:35)
    at CachedFileLoader.loadFile (C:\users\paul\_bazel_paul\lm3s4mgv\external\internal\tsc_wrapped\cache.ts:366:29)
    at C:\users\paul\_bazel_paul\lm3s4mgv\external\internal\tsc_wrapped\compiler_host.ts:413:34
    at Object.wrap (C:\users\paul\_bazel_paul\lm3s4mgv\external\internal\tsc_wrapped\perf_trace.ts:54:12)
    at CompilerHost.getSourceFile (C:\users\paul\_bazel_paul\lm3s4mgv\external\internal\tsc_wrapped\compiler_host.ts:412:22)
    at GeneratedShimsHostWrapper.getSourceFile (C:\users\paul\_bazel_paul\lm3s4mgv\execroot\angular\packages\compiler-cli\src\ngtsc\shims\src\host.ts:66:26)

This happens because we call getCanonicalFileName that returns a path that is different to the actual rootNames (passed to NgtscProgram) which are used to construct a map of generated files.

Since the generators always use the paths which are not normalized and TypeScript seems to pass "non"-canonical paths to the host getSourceFile, we should be able to stop manually calling getCanonicalFileName (this would then follow typescript internal semantics apparently)

---

Example:

// Generator Map:

'C:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ngfactory.ts' =>
'C:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ts',

// getSourceFile fileName
C:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ngfactory.ts

// after getCanonicalFileName (notice the lower-case drive name)
c:/users/paul/_bazel_paul/lm3s4mgv/execroot/angular/packages/core/index.ngfactory.ts

See source code of getCanonicalFileName.

[mary-poppins]

You can preview f368ade at https://pr27466-f368ade.ngbuilds.io/.

[JoostK]

I experience the same issue in macOS (APFS filesystem), so this is not Windows specific. Your fix works for me too 👍

[devversion]

@JoostK Good catch. Didn't know that MacOS (APFS) is case-insensitive. Updated the title/description. Thanks

[mary-poppins]

You can preview 95e6b07 at https://pr27466-95e6b07.ngbuilds.io/.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}