fix(ivy): do not use MSG_ prefix for i18nPostprocess invocation (FW-779) #27468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewKushnir
added
type: bug/fix
action: review
|
You can preview a58ac85 at https://pr27468-a58ac85.ngbuilds.io/. |
|
You can preview d52d0ff at https://pr27468-d52d0ff.ngbuilds.io/. |
alxhub
approved these changes
Dec 13, 2018
Closure Compiler doesn't allow non-goo.getMsg const names to start with `MSG_`, so we should use different prefix for const that references a result of the `i18nPostprocess` fn invocation. With this update we also append file-based prefix to i18n constants (via $$ postfix) to ensure the names are unique across codebase of a project (otherwise it might lead to errors while compiling a project with Closure Compiler).
AndrewKushnir
force-pushed
the
FW-779_no_msg_prefix
branch
from
d52d0ff
to
af9d031
Compare
|
You can preview af9d031 at https://pr27468-af9d031.ngbuilds.io/. |
AndrewKushnir
added
action: merge
ngfelixl
pushed a commit
to ngfelixl/angular
that referenced
this pull request
Jan 28, 2019
…79) (angular#27468) Closure Compiler doesn't allow non-goo.getMsg const names to start with `MSG_`, so we should use different prefix for const that references a result of the `i18nPostprocess` fn invocation. With this update we also append file-based prefix to i18n constants (via $$ postfix) to ensure the names are unique across codebase of a project (otherwise it might lead to errors while compiling a project with Closure Compiler). PR Close angular#27468
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure Compiler doesn't allow non-goo.getMsg const names to start with
MSG_, so we should use different prefix for const that references a result of thei18nPostprocessfn invocation.Also, as a part of this PR, const names received file based prefix to avoid naming collisions that Closure Compiler doesn't tolerate (there should be unique instance of
goog.getMsgcall across the whole app).PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?