Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ivy): do not use MSG_ prefix for i18nPostprocess invocation (FW-779) #27468

Closed
wants to merge 2 commits into from
Closed

fix(ivy): do not use MSG_ prefix for i18nPostprocess invocation (FW-779) #27468

wants to merge 2 commits into from

Commits on Dec 13, 2018

  1. fix(ivy): do not use MSG_ prefix for i18nPostprocess invocation (FW-779) 

    Closure Compiler doesn't allow non-goo.getMsg const names to start with `MSG_`, so we should use different prefix for const that references a result of the `i18nPostprocess` fn invocation. With this update we also append file-based prefix to i18n constants (via $$ postfix) to ensure the names are unique across codebase of a project (otherwise it might lead to errors while compiling a project with Closure Compiler).
    @AndrewKushnir
    AndrewKushnir committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    92174a3 View commit details
    Browse the repository at this point in the history

  2. fixup! fix(ivy): do not use MSG_ prefix for i18nPostprocess invocatio… 

    …n (FW-779)
    @AndrewKushnir
    AndrewKushnir committed Dec 13, 2018
    Configuration menu
    Copy the full SHA
    af9d031 View commit details
    Browse the repository at this point in the history