Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): Respect existing angular version #27495

Closed
wants to merge 1 commit into from

Conversation

kyliau
Copy link
Contributor

@kyliau kyliau commented Dec 5, 2018

If user has already installed Angular, Bazel should fetch the same
version. Otherwise, user will see an error in the post-install step
that performs version check.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau added the area: bazel Issues related to the published `@angular/bazel` build rules label Dec 5, 2018
@ngbot ngbot bot added this to the needsTriage milestone Dec 5, 2018
@mary-poppins
Copy link

You can preview 5042a28 at https://pr27495-5042a28.ngbuilds.io/.

@kyliau kyliau changed the title fix(bazel): Respect existing angular installation fix(bazel): Respect existing angular version Dec 5, 2018
@mary-poppins
Copy link

You can preview 0814a8e at https://pr27495-0814a8e.ngbuilds.io/.

If user has already installed Angular, Bazel should fetch the same
version. Otherwise, user will see an error in the post-install step
that performs version check.
@mary-poppins
Copy link

You can preview 6799ee2 at https://pr27495-6799ee2.ngbuilds.io/.

@kyliau kyliau added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Dec 6, 2018
@IgorMinar IgorMinar closed this in 4da739a Dec 6, 2018
@kyliau kyliau deleted the ng_version branch January 22, 2019 19:05
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
If user has already installed Angular, Bazel should fetch the same
version. Otherwise, user will see an error in the post-install step
that performs version check.

PR Close angular#27495
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants