Doc error - Observe geolocation updates

[fatalcaron]

📚 Docs or angular.io bug report

Description

I try your example of geolocation updates via Observables and I got an error.

🔬 Minimal Reproduction

What's the affected URL?**

https://angular.io/guide/observables

Reproduction Steps**

Copy paste your example in a new Angular project and run

🔥 Exception or Error

ERROR TypeError: Cannot read property 'isStopped' of null

🌍 Your Environment

Angular 7.0.0
Rxjs 6.3.0

Anything else relevant?

Replace the callback and it work...
const { next, error } = observer;
By:

const onSuccess: PositionCallback = (pos: Position) => {
observer.next(pos);
};

const onError: PositionErrorCallback = (error) => {
observer.error(error);
};


[ericmartinezr]

See if this PR fixes it #27260

[fatalcaron]

Quick like a lightning!!!
Thanks

[fatalcaron]

I spoke too fast, the PR does not solve the problem

[dariobraun]

Any idea how to fix this?

[fatalcaron]

@dariobraun Try this:

createWatchPosition(options?: PositionOptions): Observable<Position> {
  return new Observable((observer) => {
    // Get the next and error callbacks. These will be passed in when
    // the consumer subscribes.
    let watchId;

    const onSuccess: PositionCallback = (pos: Position) => {
      observer.next(pos);
    };

    const onError: PositionErrorCallback | any = (error) => {
      observer.error(error);
    };

    // Simple geolocation API check provides values to publish
    if (this.hasGeolocation) {
      watchId = navigator.geolocation.watchPosition(onSuccess, onError, options);
    } else {
      onError('Geolocation not available');
    }

    // When the consumer unsubscribes, clean up data ready for next subscription.
    return { unsubscribe() { navigator.geolocation.clearWatch(watchId); } };
  });
}

[rockument69]

This was fixed by PR 34705. I am therefore closing this issue.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}