Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update geolocation.ts #27260

Closed
wants to merge 1 commit into from
Closed

Update geolocation.ts #27260

wants to merge 1 commit into from

Conversation

zsl99a
Copy link

@zsl99a zsl99a commented Nov 25, 2018

Guarantee the direction of this to ensure the smooth execution of the code

fix: TypeError: null is not an object (evaluating 'this.isStopped')

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Guarantee the direction of this to ensure the smooth execution of the code

fix: TypeError: null is not an object (evaluating 'this.isStopped')
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@brandonroberts
Copy link
Contributor

Thanks for the PR @zsl99a! You must sign the CLA before this PR can move forward.

After this PR gets reviewed, is approved, and is green on CI, its ready to merge.

@brandonroberts brandonroberts added effort1: hours state: blocked target: patch This PR is targeted for the next patch release risk: low state: community Someone from the Angular community is working on this issue or submitted this PR type: bugfix labels Dec 13, 2018
@ngbot ngbot bot modified the milestones: needsTriage, Backlog Dec 13, 2018
@brandonroberts brandonroberts self-assigned this Dec 13, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no effort1: hours risk: low state: blocked state: community Someone from the Angular community is working on this issue or submitted this PR target: patch This PR is targeted for the next patch release type: bug/fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants