Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: restrict visibility of npm_package targets #27611

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Contributor

dependencies on these cause very long rebuilds which have to re-package angular.
Such tests belong in the integration/ folder - this will probably merit some discussion

dependencies on these cause very long rebuilds which have to re-package angular.
Such tests belong in the integration/ folder
@mary-poppins
Copy link

You can preview de508db at https://pr27611-de508db.ngbuilds.io/.

@alxhub alxhub added target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed target: major This PR is targeted for the next major release labels Dec 14, 2018
@mhevery mhevery closed this in d32939d Dec 14, 2018
mhevery pushed a commit that referenced this pull request Dec 14, 2018
dependencies on these cause very long rebuilds which have to re-package angular.
Such tests belong in the integration/ folder

PR Close #27611
@alexeagle alexeagle deleted the packages_private branch December 17, 2018 20:19
ngfelixl pushed a commit to ngfelixl/angular that referenced this pull request Jan 28, 2019
dependencies on these cause very long rebuilds which have to re-package angular.
Such tests belong in the integration/ folder

PR Close angular#27611
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants